From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752891Ab1AXAbs (ORCPT ); Sun, 23 Jan 2011 19:31:48 -0500 Received: from tundra.namei.org ([65.99.196.166]:44515 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752608Ab1AXAbr (ORCPT ); Sun, 23 Jan 2011 19:31:47 -0500 Date: Mon, 24 Jan 2011 11:31:17 +1100 (EST) From: James Morris To: Olof Johansson cc: linux-kernel@vger.kernel.org, Debora Velarde , Rajiv Andrade , Marcel Selhorst , tpmdd-devel@lists.sourceforge.net, Matthew Garrett , linux-security-module@vger.kernel.org Subject: Re: [PATCH] tpm: fix panic caused by "tpm: Autodetect itpm devices" In-Reply-To: Message-ID: References: <1294370641-6791-1-git-send-email-olof@lixom.net> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Jan 2011, Olof Johansson wrote: > On Thu, Jan 6, 2011 at 7:24 PM, Olof Johansson wrote: > > commit 3f0d3d016d89a5efb8b926d4707eb21fa13f3d27 adds a check for > > PNP device id to the common tpm_tis_init() function, which in some > > cases (force=1) will be called without the device being a member of > > a pnp_dev. Oopsing and panics ensue. > > > > Move the test up to before the call to tpm_tis_init(), since it > > just modifies a global variable anyway. Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#for-linus -- James Morris