From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x2257qSxl1hn3Yo+5taauwCRDEPCbF8KzqeWfk9UGDMe+o+fT/P4mLgFZ/jD681LQSUv+qBdr ARC-Seal: i=1; a=rsa-sha256; t=1517049079; cv=none; d=google.com; s=arc-20160816; b=ZlML4g3NTOE4SVWjXYUER54F0yiCd5799yDexHSAl0oxnnRVL2xWFXEl/W/i/XU+LM 1oHOXcTS8mcDouVZc82ATdp8tvwJ9S5/wsRdgtGemHPUTSE3cLxeIAxKQq0SCwrXQxu0 5hyDMWyyp7HxoHXdRGrw0WavEFrJ+FGWg6PTgBj2hitYh7qz+yQnB5ZdkfzeVnvV680q u7KBauEnYRQ/YYiOllavuqsS52Gyv532xjaqHzZBCD+NY5bP8raB4wFGzfaJp2527lb8 QrD8ovns5fWkxngOrbGpJiqavFLg23sFS4EhXxHdkn+toH2a7Dk2jcEiRWpDv+BRPioS qroQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=subject:mime-version:user-agent:references:message-id:in-reply-to :cc:to:from:date:delivered-to:delivered-to:list-id:list-subscribe :list-unsubscribe:list-help:list-post:precedence:mailing-list :arc-authentication-results; bh=2htvV9rxn7DGhrHpP5wnEZnInu5Bsra7fTCWyiwvUwg=; b=Qpn74qpOrz/DtNR6GA8HYn9w6CVq2fLXY4OiaWiHRYEDNwRqbfO9mmXsROXnimXwCq Q9GmUuMNso9kBlxLDXQC76PQbhVsE/lNYABNnrUmM1tB7awRVIBOD/RG2kHn1+jrW59t 2TmVRRG6ZI/UrbZrxFmgvs8Md0eEC+H691XUMkiv+PnB4CXEWkr6ky9dkBLbYgPgF+o6 O5YbwueNJ0854XhMQJQzdJqtyDkz3CvS6YdOesXULdUr1r6Z7jYxmSbCft5BP3ilHzzX bxfF5YhassB8PBLlZbrucfFQ1ze4nX9oI7PDfwWIc91YxvozXj6CiaOD4kSx58NM7Hwv cdoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of kernel-hardening-return-11471-gregkh=linuxfoundation.org@lists.openwall.com designates 195.42.179.200 as permitted sender) smtp.mailfrom=kernel-hardening-return-11471-gregkh=linuxfoundation.org@lists.openwall.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of kernel-hardening-return-11471-gregkh=linuxfoundation.org@lists.openwall.com designates 195.42.179.200 as permitted sender) smtp.mailfrom=kernel-hardening-return-11471-gregkh=linuxfoundation.org@lists.openwall.com Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm List-Post: List-Help: List-Unsubscribe: List-Subscribe: Date: Fri, 26 Jan 2018 23:01:21 +0100 (CET) From: Jiri Kosina To: Kees Cook cc: Andrew Morton , Andy Lutomirski , Jann Horn , Ingo Molnar , Laura Abbott , Thomas Gleixner , Al Viro , Sahara , "Levin, Alexander (Sasha Levin)" , Michal Hocko , Andrea Arcangeli , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com In-Reply-To: <20180117055015.GA15256@beast> Message-ID: References: <20180117055015.GA15256@beast> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: [kernel-hardening] Re: [PATCH] fork: Allow stack to be wiped on fork X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589817624643319879?= X-GMAIL-MSGID: =?utf-8?q?1590741255400677817?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Tue, 16 Jan 2018, Kees Cook wrote: > diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h > index 34f053a150a9..091f53fe31cc 100644 > --- a/include/linux/thread_info.h > +++ b/include/linux/thread_info.h > @@ -43,7 +43,9 @@ enum { > #define THREAD_ALIGN THREAD_SIZE > #endif > > -#if IS_ENABLED(CONFIG_DEBUG_STACK_USAGE) || IS_ENABLED(CONFIG_DEBUG_KMEMLEAK) > +#if IS_ENABLED(CONFIG_DEBUG_STACK_USAGE) || \ > + IS_ENABLED(CONFIG_DEBUG_KMEMLEAK) || \ > + IS_ENABLED(CONFIG_CLEAR_STACK_FORK) > # define THREADINFO_GFP (GFP_KERNEL_ACCOUNT | __GFP_ZERO) > #else > # define THREADINFO_GFP (GFP_KERNEL_ACCOUNT) > diff --git a/kernel/fork.c b/kernel/fork.c > index 2295fc69717f..215b1ce2b2cd 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -215,7 +215,7 @@ static unsigned long *alloc_thread_stack_node(struct task_struct *tsk, int node) > if (!s) > continue; > > -#ifdef CONFIG_DEBUG_KMEMLEAK > +#if IS_ENABLED(CONFIG_DEBUG_KMEMLEAK) || IS_ENABLED(CONFIG_CLEAR_STACK_FORK) > /* Clear stale pointers from reused stack. */ > memset(s->addr, 0, THREAD_SIZE); > #endif Is there any good reason not to do it symmetricaly also for non-vmapped stacks? (by passing __GFP_ZERO to alloc_pages_node())? Thanks, -- Jiri Kosina SUSE Labs