From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751537Ab2DDEJX (ORCPT ); Wed, 4 Apr 2012 00:09:23 -0400 Received: from tundra.namei.org ([65.99.196.166]:47591 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088Ab2DDEJV (ORCPT ); Wed, 4 Apr 2012 00:09:21 -0400 Date: Wed, 4 Apr 2012 14:06:19 +1000 (EST) From: James Morris To: "Eric W. Biederman" cc: Andrew Morton , "Serge E. Hallyn" , Philipp Reisner , Patrick McHardy , Andrew Morgan , Vasiliy Kulikov , David Howells , Neil Brown , Michal Januszewski , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH] userns: Replace netlink uses of cap_raised with capable. In-Reply-To: Message-ID: References: User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Apr 2012, Eric W. Biederman wrote: > In the initial user_namespace the only difference between between > cap_raised(current_cap(), CAP_SYS_ADMIN) and capable(CAP_SYS_ADMIN) > are a few sanity checks and the fact that capable(CAP_SYS_ADMIN) > sets PF_SUPERPRIV if we use the capability. > > Since we are going to be using root privilege setting PF_SUPERPRIV > seems the right thing to do. Agreed. Reviewed-by: James Morris - James -- James Morris