From: James Morris <jmorris@namei.org>
To: Kees Cook <keescook@chromium.org>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Will Drewry <wad@chromium.org>,
James Morris <james.l.morris@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] samples/seccomp: fix endianness bug in LO_ARG define
Date: Fri, 3 Aug 2012 14:37:27 +1000 (EST) [thread overview]
Message-ID: <alpine.LRH.2.02.1208031437010.25196@tundra.namei.org> (raw)
In-Reply-To: <CAGXu5j+PAk4xbcr=3=O4qBD=+1++i1DeE=TX5S9vT3UivcR72w@mail.gmail.com>
On Tue, 31 Jul 2012, Kees Cook wrote:
> On Tue, Jul 31, 2012 at 7:15 AM, Heiko Carstens
> <heiko.carstens@de.ibm.com> wrote:
> > From: Heiko Carstens <heiko.carstens@de.ibm.com>
> >
> > The LO_ARG define needs to consider endianness also for 32 bit builds.
> >
> > The "bpf_fancy" test case didn't work on s390 in 32 bit and compat mode
> > because the LO_ARG define resulted in a BPF program which read the upper
> > halve of the 64 bit system call arguments instead of the lower halves.
> >
> > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> Good catch; thanks for the fix!
>
> Acked-by: Kees Cook <keescook@chromium.org>
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2012-08-03 4:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 14:15 Heiko Carstens
2012-07-31 16:21 ` Kees Cook
2012-08-03 4:37 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.02.1208031437010.25196@tundra.namei.org \
--to=jmorris@namei.org \
--cc=heiko.carstens@de.ibm.com \
--cc=james.l.morris@oracle.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®