From: James Morris <jmorris@namei.org>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: Oleg Nesterov <oleg@redhat.com>,
lucas.de.marchi@gmail.com, David Howells <dhowells@redhat.com>,
James Morris <james.l.morris@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/7] KEYS: split call to call_usermodehelper_fns()
Date: Tue, 12 Mar 2013 12:05:53 +1100 (EST) [thread overview]
Message-ID: <alpine.LRH.2.02.1303121205090.25612@tundra.namei.org> (raw)
In-Reply-To: <1363049291-946-4-git-send-email-lucas.demarchi@profusion.mobi>
On Mon, 11 Mar 2013, Lucas De Marchi wrote:
> Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of
> calling call_usermodehelper_fns(). In case there's an OOM in this last
> function the cleanup function may not be called - in this case we would
> miss a call to key_put().
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Acked-by: James Morris <james.l.morris@oracle.com>
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2013-03-12 1:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 0:48 [PATCH v3 1/7] kernel/sys.c: Use the simpler call_usermodehelper() Lucas De Marchi
2013-03-12 0:48 ` [PATCH v3 2/7] usermodehelper: Export _exec() and _setup() functions Lucas De Marchi
2013-03-12 20:31 ` Andrew Morton
2013-03-12 21:52 ` Lucas De Marchi
2013-03-12 22:00 ` Andrew Morton
2013-03-12 0:48 ` [PATCH v3 3/7] kmod: split call to call_usermodehelper_fns() Lucas De Marchi
2013-03-12 0:48 ` [PATCH v3 4/7] KEYS: " Lucas De Marchi
2013-03-12 1:05 ` James Morris [this message]
2013-03-12 0:48 ` [PATCH v3 5/7] coredump: remove trailling whitespaces Lucas De Marchi
2013-03-12 0:48 ` [PATCH v3 6/7] Split remaining calls to call_usermodehelper_fns() Lucas De Marchi
2013-03-12 0:48 ` [PATCH v3 7/7] kmod: remove call_usermodehelper_fns() Lucas De Marchi
2013-03-25 12:56 ` [PATCH v3 4/7] KEYS: split call to call_usermodehelper_fns() David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.02.1303121205090.25612@tundra.namei.org \
--to=jmorris@namei.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@profusion.mobi \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®