From: Mikulas Patocka <mpatocka@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, dm-devel@redhat.com,
Andrew Morton <akpm@linux-foundation.org>,
Lisa Du <chunlingdu1@gmail.com>,
Mandeep Singh Baines <msb@chromium.org>
Subject: work item migration bug when a CPU is disabled
Date: Tue, 18 Feb 2014 20:57:11 -0500 (EST) [thread overview]
Message-ID: <alpine.LRH.2.02.1402182040100.28214@file01.intranet.prod.int.rdu2.redhat.com> (raw)
Hi Tejun
Two years ago, I reported a bug in workqueues - a work item that is
supposed to be bound to a specific CPU can be migrated to a different CPU
when the origianl CPU is disabled by writing zero to
/sys/devices/system/cpu/cpu*/online
This causes crashes in dm-crypt, because it assumes that a work item stays
on the same CPU.
There was some discussion (see here
http://www.redhat.com/archives/dm-devel/2012-March/msg00034.html ), but
the bug is still unfixed and I've just got another bug report about
dm-crypt crashing because of it.
I'd like to ask - are you going to fix the workqueue code so that work
item migrations can't happen? - or are you going to specify that work item
migration can happen and do you require that all code that relies on the
fact that a work item executes on a single CPU be fixed?
Here I'm sending a simple kernel module that shows the bug.
Mikulas
/*
* A proof of concept that a work item executed on a workqueue may change CPU
* when CPU hot-unplugging is used.
* Compile this as a module and run:
* insmod test.ko; sleep 1; echo 0 >/sys/devices/system/cpu/cpu1/online
* You see that the work item starts executing on CPU 1 and ends up executing
* on different CPU, usually 0.
*/
#include <linux/module.h>
#include <linux/delay.h>
static struct workqueue_struct *wq;
static struct work_struct work;
static void do_work(struct work_struct *w)
{
printk("starting work on cpu %d\n", smp_processor_id());
msleep(10000);
printk("finishing work on cpu %d\n", smp_processor_id());
}
static int __init test_init(void)
{
printk("module init\n");
wq = alloc_workqueue("testd", WQ_MEM_RECLAIM | WQ_CPU_INTENSIVE,
1);
if (!wq) {
printk("alloc_workqueue failed\n");
return -ENOMEM;
}
INIT_WORK(&work, do_work);
queue_work_on(1, wq, &work);
return 0;
}
static void __exit test_exit(void)
{
destroy_workqueue(wq);
printk("module exit\n");
}
module_init(test_init)
module_exit(test_exit)
MODULE_LICENSE("GPL");
next reply other threads:[~2014-02-19 1:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 1:57 Mikulas Patocka [this message]
2014-02-20 0:29 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.02.1402182040100.28214@file01.intranet.prod.int.rdu2.redhat.com \
--to=mpatocka@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chunlingdu1@gmail.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=msb@chromium.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®