From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 64739C433EF for ; Tue, 12 Jun 2018 17:19:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 191F9208B4 for ; Tue, 12 Jun 2018 17:19:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 191F9208B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933811AbeFLRTd (ORCPT ); Tue, 12 Jun 2018 13:19:33 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:52114 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753448AbeFLRTb (ORCPT ); Tue, 12 Jun 2018 13:19:31 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4755A8314C; Tue, 12 Jun 2018 17:19:31 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (file01.intranet.prod.int.rdu2.redhat.com [10.11.5.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D46EC111CB8C; Tue, 12 Jun 2018 17:19:28 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (localhost [127.0.0.1]) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4) with ESMTP id w5CHJSw8011613; Tue, 12 Jun 2018 13:19:28 -0400 Received: from localhost (mpatocka@localhost) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4/Submit) with ESMTP id w5CHJSRM011610; Tue, 12 Jun 2018 13:19:28 -0400 X-Authentication-Warning: file01.intranet.prod.int.rdu2.redhat.com: mpatocka owned process doing -bs Date: Tue, 12 Jun 2018 13:19:28 -0400 (EDT) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: Alan Stern cc: Ming Lei , Greg Kroah-Hartman , USB list , Kernel development list Subject: Re: [PATCH] usb: don't offload isochronous urb completions to ksoftirq In-Reply-To: Message-ID: References: User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 12 Jun 2018 17:19:31 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 12 Jun 2018 17:19:31 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mpatocka@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jun 2018, Alan Stern wrote: > On Tue, 12 Jun 2018, Mikulas Patocka wrote: > > > > How about making the softirq thread's priority adjustable? > > > > But you would have to argue with softirq maintainers about it - and you > > say that you don't have time for that. > > But maybe _you_ do... ksoftirqd has priority 0 - it is not suitable for real-time tasks, such as audio. In my opinion, it is much easier to fix this in the ehci driver (by not offloading isochronous completions), than to design a new real-time-capable ksoftirqd. > > > As for coordinating with the softirq maintainers -- whether I want to > > > or not isn't the issue. Right now I don't have _time_ to do it. > > > > > > Alan Stern > > > > I am wondering - whats the purpose of that patch > > 428aac8a81058e2303677a8fbf26670229e51d3a at all? The patch shows some > > performance difference, but they are minor, about 1%. > > > > If you want to call the urb callback as soon as possible - why don't you > > just call it? Why do you need to offload the callback to a softirq thread? > > Please read the Changelog entry for commit 94dfd7edfd5c. Basically the > idea was to reduce overall latency by not doing as much work in an > interrupt handler. > > Alan Stern snd_complete_urb is doing nothing but submitting the same urb again. Is resubmitting the urb really causing so much latency that you can't do it in the interrupt handler? Mikulas