From: Keith Busch <keith.busch@intel.com>
To: "Matias Bjørling" <m@bjorling.me>
Cc: willy@linux.intel.com, keith.busch@intel.com,
sbradshaw@micron.com, axboe@fb.com, tom.leiming@gmail.com,
hch@infradead.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v8] NVMe: convert to blk-mq
Date: Mon, 16 Jun 2014 09:57:03 -0600 (MDT) [thread overview]
Message-ID: <alpine.LRH.2.03.1406160931400.4699@AMR> (raw)
In-Reply-To: <1402661396-19207-2-git-send-email-m@bjorling.me>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 829 bytes --]
On Fri, 13 Jun 2014, Matias Bjørling wrote:
> This converts the current NVMe driver to utilize the blk-mq layer.
> static void nvme_reset_notify(struct pci_dev *pdev, bool prepare)
> {
> - struct nvme_dev *dev = pci_get_drvdata(pdev);
> + struct nvme_dev *dev = pci_get_drvdata(pdev);
>
> - if (prepare)
> - nvme_dev_shutdown(dev);
> - else
> - nvme_dev_resume(dev);
> + spin_lock(&dev_list_lock);
> + if (prepare)
> + list_del_init(&dev->node);
> + else
> + list_add(&dev->node, &dev_list);
> + spin_unlock(&dev_list_lock);
> }
> + if (nvme_create_queue(dev->queues[i], i))
> break;
> }
The above change was just error injection test code so you can cause
a device to become unresponsive and trigger the timeout handling.
This latest is otherwise stable on my dev machine.
next prev parent reply other threads:[~2014-06-16 15:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 12:09 [PATCH v8] convert nvme driver " Matias Bjørling
2014-06-13 12:09 ` [PATCH v8] NVMe: convert " Matias Bjørling
2014-06-16 15:57 ` Keith Busch [this message]
2014-06-16 16:49 ` Matias Bjorling
2014-06-24 19:19 ` Matias Bjorling
2014-06-24 20:33 ` Keith Busch
2014-06-24 21:18 ` Matias Bjørling
2014-06-24 21:47 ` Keith Busch
2014-06-24 21:57 ` Matias Bjørling
2014-06-13 13:27 ` [PATCH v8] convert nvme driver " Christoph Hellwig
2014-06-13 13:55 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.03.1406160931400.4699@AMR \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m@bjorling.me \
--cc=sbradshaw@micron.com \
--cc=tom.leiming@gmail.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®