From: Keith Busch <keith.busch@intel.com>
To: Matias Bjorling <m@bjorling.me>
Cc: Jens Axboe <axboe@fb.com>, Keith Busch <keith.busch@intel.com>,
Matthew Wilcox <willy@linux.intel.com>,
"Sam Bradshaw (sbradshaw)" <sbradshaw@micron.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-nvme <linux-nvme@lists.infradead.org>,
Christoph Hellwig <hch@infradead.org>,
Rob Nelson <rlnelson@google.com>,
Ming Lei <tom.leiming@gmail.com>
Subject: Re: [PATCH v11] NVMe: Convert to blk-mq
Date: Thu, 14 Aug 2014 12:20:24 -0600 (MDT) [thread overview]
Message-ID: <alpine.LRH.2.03.1408141209500.14603@AMR> (raw)
In-Reply-To: <53ECD842.40302@bjorling.me>
On Thu, 14 Aug 2014, Matias Bjorling wrote:
>> nr_tags must be uninitialized or screwed up somehow, otherwise I don't
>> see how that kmalloc() could warn on being too large. Keith, are you
>> running with slab debugging? Matias, might be worth trying.
The queue's tags were freed in 'blk_mq_map_swqueue' because some queues
weren't mapped to a s/w queue, but the driver has a pointer to that
freed memory, so it's a use-after-free error.
This part in the driver looks different than it used to be in v8 when I
last tested. The nvme_queue used to have a pointer to the 'hctx', but now
it points directly to the 'tags', but it doesn't appear to be very safe.
next prev parent reply other threads:[~2014-08-14 18:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 9:07 [PATCH v11] Convert NVMe driver " Matias Bjørling
2014-07-26 9:07 ` [PATCH v11] NVMe: Convert " Matias Bjørling
2014-08-10 17:27 ` Matias Bjørling
2014-08-13 22:27 ` Keith Busch
2014-08-14 8:25 ` Matias Bjørling
2014-08-14 15:09 ` Jens Axboe
2014-08-14 15:33 ` Keith Busch
2014-08-14 15:39 ` Matias Bjorling
2014-08-14 18:20 ` Keith Busch [this message]
2014-08-14 23:09 ` Keith Busch
2014-08-15 10:09 ` Matias Bjorling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.03.1408141209500.14603@AMR \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m@bjorling.me \
--cc=rlnelson@google.com \
--cc=sbradshaw@micron.com \
--cc=tom.leiming@gmail.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome