From: Meelis Roos <mroos@linux.ee>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Steffen Klassert <steffen@klassert.de>,
netdev@vger.kernel.org,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: bisected regression: 3c59x corrupts packets in 3.17-rc5
Date: Tue, 16 Sep 2014 13:32:31 +0300 (EEST) [thread overview]
Message-ID: <alpine.LRH.2.11.1409161327110.24403@adalberg.ut.ee> (raw)
In-Reply-To: <20140916101704.GA3792@hmsreliant.think-freely.org>
[ Fixed Steffen Klasserts bouncing email address as per the bounce message ]
> > Somewhere between 3.17.0-rc3 and 3.17.0-rc5 I started seeing dropped ssh
> > connections to a couple of test servers with dual AthlonMP (32-bit) and
> > 3C90x family of NICs (3Com Corporation 3c980-C 10/100baseTX NIC
> > [Python-T] (rev 78) in one server and 3Com Corporation 3c905C-TX/TX-M
> > [Tornado] (rev 78) in the other server). Bisect leads to the following
> > commit:
> >
> > 98ea232cf63961fad734cc8c5e07e8915ec73073 is the first bad commit
> > commit 98ea232cf63961fad734cc8c5e07e8915ec73073
> > Author: Neil Horman <nhorman@tuxdriver.com>
> > Date: Thu Sep 4 06:13:38 2014 -0400
> >
> > 3c59x: avoid panic in boomerang_start_xmit when finding page address:
> > ...
> >
> I'm guessing the above change has uncovered another bug, mostly likely an
> exhaustion of dma space on your system. Nothing in the transmit path there does
> any error checking for successful dma mapping, which it really should. I'd be
> willing to be that any dma mapping error leads to a leak in the mapping table.
> Does your system have an iommu, or does it use swiotlb? If its the latter, can
> you increase the swiotlb table space and see if that relieves the problem? In
> the interim, I'll start adding some error checking to the transmit path.
# CONFIG_IOMMU_SUPPORT is not set
nothing matching iommu or iotlb in dmesg. I thought the system does not
have any - K7 CPUs and AMD 760MP chipset with normal AGP gart.
[ 3.763519] agpgart-amdk7 0000:00:00.0: AMD 760MP chipset
[ 3.782995] agpgart-amdk7 0000:00:00.0: AGP aperture is 64M @ 0xf8000000
--
Meelis Roos (mroos@linux.ee)
next prev parent reply other threads:[~2014-09-16 10:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 23:14 Meelis Roos
2014-09-16 10:17 ` Neil Horman
2014-09-16 10:32 ` Meelis Roos [this message]
2014-09-16 14:31 ` Neil Horman
2014-09-16 14:32 ` [RFC PATCH] 3c59x: Add dma error checking and recovery Neil Horman
2014-09-16 20:29 ` bisected regression: 3c59x corrupts packets in 3.17-rc5 David Miller
2014-09-17 10:27 ` Neil Horman
2014-09-17 12:43 ` mroos
2014-09-17 12:56 ` Neil Horman
2014-09-17 13:04 ` [PATCH 1/2] 3c59x: Add dma error checking and recovery Neil Horman
2014-09-17 13:04 ` [PATCH 2/2] 3c59x: Fix bad offset spec in skb_frag_dma_map Neil Horman
2014-09-19 20:29 ` David Miller
2014-09-19 20:29 ` [PATCH 1/2] 3c59x: Add dma error checking and recovery David Miller
2014-09-20 1:19 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.11.1409161327110.24403@adalberg.ut.ee \
--to=mroos@linux.ee \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=steffen@klassert.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®