From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754007AbaIVMmh (ORCPT ); Mon, 22 Sep 2014 08:42:37 -0400 Received: from tundra.namei.org ([65.99.196.166]:34475 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753528AbaIVMmg (ORCPT ); Mon, 22 Sep 2014 08:42:36 -0400 Date: Mon, 22 Sep 2014 22:42:30 +1000 (EST) From: James Morris To: David Howells cc: keyrings@linux-nfs.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] KEYS: Changes for keyrings for security/next In-Reply-To: <22597.1411342588@warthog.procyon.org.uk> Message-ID: References: <32370.1410886755@warthog.procyon.org.uk> <22597.1411342588@warthog.procyon.org.uk> User-Agent: Alpine 2.11 (LRH 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Sep 2014, David Howells wrote: > James Morris wrote: > > > > Can you please pull these changes into security/next. They include the fixes > > > tag I previously requested as there's a dependency between these changes and > > > the fixes. > > > > > > > I'm getting this warning after pulling your code: > > > > CC crypto/hash_info.o > > crypto/asymmetric_keys/asymmetric_type.c: In function > > asymmetric_key_hex_to_key_id: > > crypto/asymmetric_keys/asymmetric_type.c:110: warning: ignoring return > > value of hex2bin, declared with attribute warn_unused_result > > I've posted an additional patch that moves some of the prevalidation to after > the memory allocation in asymmetric_key_hex_to_key_id() and added it onto the > keys-next branch. Here's a revised pull request. > --- > Can you please pull these changes into security/next. They include the fixes > tag I previously requested as there's a dependency between these changes and > the fixes. > Ok, pulled to my next branch. -- James Morris