From: James Morris <jmorris@namei.org>
To: Dmitry Kasatkin <d.kasatkin@samsung.com>
Cc: zohar@linux.vnet.ibm.com, linux-security-module@vger.kernel.org,
linux-ima-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, jack@suse.cz,
dmitry.kasatkin@gmail.com
Subject: Re: [PATCH 1/2] ima: check xattr value length in ima_inode_setxattr()
Date: Fri, 24 Oct 2014 13:55:27 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LRH.2.11.1410241355020.30398@namei.org> (raw)
In-Reply-To: <5b1f234e8515c10c96a16868ff4341f29460f38f.1414071910.git.d.kasatkin@samsung.com>
On Thu, 23 Oct 2014, Dmitry Kasatkin wrote:
> ima_inode_setxattr() can be called with no value. Function does not
> check the length so that following command can be used to produce
> kernel oops: setfattr -n security.ima FOO. This patch fixes it.
I'd like to see more review/acks on this before sending it to Linus.
Mimi?
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2014-10-24 2:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 13:47 [PATCH 0/2] integrity fixes Dmitry Kasatkin
2014-10-23 13:47 ` [PATCH 1/2] ima: check xattr value length in ima_inode_setxattr() Dmitry Kasatkin
2014-10-23 15:40 ` Jan Kara
2014-10-23 15:59 ` Dmitry Kasatkin
2014-10-23 16:04 ` Jan Kara
2014-10-24 2:55 ` James Morris [this message]
2014-10-24 3:48 ` Mimi Zohar
2014-10-23 13:47 ` [PATCH 2/2] evm: check xattr value length in evm_inode_setxattr() Dmitry Kasatkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.11.1410241355020.30398@namei.org \
--to=jmorris@namei.org \
--cc=d.kasatkin@samsung.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®