From: James Morris <jmorris@namei.org>
To: David Howells <dhowells@redhat.com>
Cc: linux-security-module@vger.kernel.org, keyrings@linux-nfs.org,
David Jeffery <djeffery@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Don't leak a key reference if request_key() tries to use a revoked keyring
Date: Mon, 16 Feb 2015 13:27:31 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LRH.2.11.1502161327210.30698@namei.org> (raw)
In-Reply-To: <20150212164531.19850.29188.stgit@warthog.procyon.org.uk>
On Thu, 12 Feb 2015, David Howells wrote:
> From: David Jeffery <djeffery@redhat.com>
>
> If a request_key() call to allocate and fill out a key attempts to insert the
> key structure into a revoked keyring, the key will leak, using memory and part
> of the user's key quota until the system reboots. This is from a failure of
> construct_alloc_key() to decrement the key's reference count after the attempt
> to insert into the requested keyring is rejected.
>
> key_put() needs to be called in the link_prealloc_failed callpath to ensure
> the unused key is released.
>
> Signed-off-by: David Jeffery <djeffery@redhat.com>
> Signed-off-by: David Howells <dhowells@redhat.com>
Applied.
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2015-02-16 2:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 16:45 David Howells
2015-02-16 2:27 ` James Morris [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-02-11 21:26 David Jeffery
2015-02-12 16:46 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.11.1502161327210.30698@namei.org \
--to=jmorris@namei.org \
--cc=dhowells@redhat.com \
--cc=djeffery@redhat.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®