From: Eric Wheeler <bcache@lists.ewheeler.net>
To: Jens Axboe <axboe@kernel.dk>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
linux-bcache@vger.kernel.org, dave@stgolabs.net,
linux-kernel@vger.kernel.org, Kai Krakow <kai@kaishome.de>,
Wido den Hollander <wido@widodh.nl>
Subject: Re: [PULL] bcache: multiple updates
Date: Mon, 31 Oct 2016 19:35:58 -0700 (PDT) [thread overview]
Message-ID: <alpine.LRH.2.11.1610311934310.4080@mail.ewheeler.net> (raw)
In-Reply-To: <6bda49c5-5ed8-939f-aab3-faa9c8127ff0@kernel.dk>
On Sun, 30 Oct 2016, Jens Axboe wrote:
> On 10/30/2016 08:00 AM, Kent Overstreet wrote:
> > On Sat, Oct 29, 2016 at 06:32:38PM -0700, Eric Wheeler wrote:
> > > On Thu, 27 Oct 2016, Jens Axboe wrote:
> > >
> > > > On 10/27/2016 05:27 PM, Eric Wheeler wrote:
> > > > > Hi Jens,
> > > > >
> > > > > Please pull this v4.9-rc2 based series of bcache updates for v4.9-rc3:
> > > > > (You may disregard the previous -rc1-based request.)
> > > > >
> > > > > git pull https://bitbucket.org/ewheelerinc/linux.git
> > > > > v4.9-rc2-bcache-updates
> > > > >
> > > > > Thank you!
> > > > >
> > > > > --
> > > > > Eric Wheeler
> > > > >
> > > > > ]# git log --oneline v4.9-rc2..HEAD
> > > > > bd532a6 bcache: partition support: add 16 minors per bcacheN device
> > > > > 3312845 bcache: Make gc wakeup sane, remove set_task_state()
> > > > > 6bb7f1e bcache: update bio->bi_opf bypass/writeback REQ_ flag hints
> > > > > 3d58a09 bcache: documentation for ioprio cache hinting
> > > > > 2e8884b bcache: introduce per-process ioprio-based bypass/writeback
> > > > > hints
> > > >
> > > > How many of these are applicable to 4.9-rc3? I took a quick look at
> > > > them, and some of them look like they should go into the 4.10 branch
> > > > instead. We're after the merge window, so only strict fixes. Cleanups
> > > > and no features, no go.
> > >
> > > 3312845 might need to be in 4.9. Not sure, kent asked me to pick it up in
> > > my next pull request. 4.10 is fine for the rest.
> > >
> > > Kent, Davidlohr, does 3312845 need to land in 4.9 for some reason?
> >
> > No, that can wait until 4.10.
>
> Great, that's what it looked like.
>
> Eric, three things. The first is that you based this branch as if it was
> going into 4.9, which means if I pull it into my 4.10 branch, I get a
> ton of extra stuff that has been added to master since. Not a huge
> problem, I can just generate the patches and apply them.
>
> Secondly, you are depending on REQ_THROTTLED, which in the 4.10 series,
> has been modified:
>
> commit 8d2bbd4c8236e9e38e6b36ac9e2c54fdcfe5b335
> Author: Christoph Hellwig <hch@lst.de>
> Date: Thu Oct 20 15:12:12 2016 +0200
>
> block: replace REQ_THROTTLED with a bio flag
>
> And lastly, would you mind using the regular git request-pull to
> generate your pull requests? It's what everybody else is using, and
> honestly I think it's a lot more readable than the oneline thing you are
> doing.
>
> Please resend the series against for-4.10/block and we can get it
> applied, thanks.
Will do, thanks!
-Eric
--
Eric Wheeler
>
> --
> Jens Axboe
>
>
>
next prev parent reply other threads:[~2016-11-01 2:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LRH.2.11.1610262037160.24191@mail.ewheeler.net>
[not found] ` <5160da7c-e38e-1527-2b09-2ca240df57c3@kernel.dk>
2016-10-30 1:32 ` Eric Wheeler
2016-10-30 3:44 ` Davidlohr Bueso
2016-10-30 14:00 ` Kent Overstreet
2016-10-30 15:01 ` Jens Axboe
2016-11-01 2:35 ` Eric Wheeler [this message]
2016-12-06 19:47 ` [PULL] bcache: based on for-4.10/block, " Eric Wheeler
2016-12-15 1:50 ` Eric Wheeler
2016-12-15 4:47 ` Jens Axboe
2017-01-31 19:14 ` Eric Wheeler
2017-01-31 19:27 ` Jens Axboe
2017-01-31 23:17 ` Eric Wheeler
2017-02-28 2:00 ` Eric Wheeler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.11.1610311934310.4080@mail.ewheeler.net \
--to=bcache@lists.ewheeler.net \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=kai@kaishome.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wido@widodh.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®