From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932438AbdJ0TLE (ORCPT ); Fri, 27 Oct 2017 15:11:04 -0400 Received: from mx.ewheeler.net ([66.155.3.69]:53248 "EHLO mail.ewheeler.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751610AbdJ0TK6 (ORCPT ); Fri, 27 Oct 2017 15:10:58 -0400 X-Greylist: delayed 307 seconds by postgrey-1.27 at vger.kernel.org; Fri, 27 Oct 2017 15:10:58 EDT Date: Fri, 27 Oct 2017 19:05:45 +0000 (UTC) From: Eric Wheeler X-X-Sender: lists@mail.ewheeler.net To: Michael Lyle cc: Coly Li , Liang Chen , linux-bcache@vger.kernel.org, kent.overstreet@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] bcache: explicitly destroy mutex while exiting In-Reply-To: Message-ID: References: <20171010090049.6596-1-liangchen.linux@gmail.com> <01f432e8-950a-fc9f-150d-0b51fa9e7559@coly.li> User-Agent: Alpine 2.11 (LRH 23 2013-08-11) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="1641074820-1074948329-1509131149=:24585" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1641074820-1074948329-1509131149=:24585 Content-Type: TEXT/PLAIN; charset=utf-8 Content-Transfer-Encoding: 8BIT On Tue, 10 Oct 2017, Michael Lyle wrote: > On 10/10/2017 05:25 AM, Coly Li wrote: > > On 2017/10/10 下午5:00, Liang Chen wrote: > >> mutex_destroy does nothing most of time, but it's better to call > >> it to make the code future proof and it also has some meaning > >> for like mutex debug. > >> > >> As Coly pointed out in a previous review, bcache_exit() may not be > >> able to handle all the references properly if userspace registers > >> cache and backing devices right before bch_debug_init runs and > >> bch_debug_init failes later. So not exposing userspace interface > >> until everything is ready to avoid that issue. > >> > >> Signed-off-by: Liang Chen > > > > Hi Liang, > > > > No more comment from me, it looks good. Thanks. > > > > Reviewed-by: Coly Li > > Looks good to me too. > > Reviewed-by: Michael Lyle Should this Cc: stable to avoid the register race (possible crash?) described by Liang in other stable kernels? Reviewed-by: Eric Wheeler > > -- > To unsubscribe from this list: send the line "unsubscribe linux-bcache" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > --1641074820-1074948329-1509131149=:24585--