From: James Morris <jmorris@namei.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: serge.hallyn@canonical.com, arnd@arndb.de, tglx@linutronix.de,
linux-kernel@vger.kernel.org, james.l.morris@oracle.com,
serge@hallyn.com, paul@paul-moore.com,
john.johansen@canonical.com, sds@tycho.nsa.gov,
casey@schaufler-ca.com, penguin-kernel@I-love.SAKURA.ne.jp,
neilb@suse.de, edumazet@google.com, jlayton@primarydata.com,
linux-security-module@vger.kernel.org, y2038@lists.linaro.org
Subject: Re: [PATCH v2 3/5] security: Introduce security_settime64()
Date: Thu, 30 Jul 2015 18:23:18 +1000 (AEST) [thread overview]
Message-ID: <alpine.LRH.2.20.1507301822080.4374@namei.org> (raw)
In-Reply-To: <50b61ce23a73b68c3c55d6d9aa416af29001205a.1438170155.git.baolin.wang@linaro.org>
On Wed, 29 Jul 2015, Baolin Wang wrote:
> security_settime() uses a timespec, which is not year 2038 safe
> on 32bit systems. Thus this patch introduces the security_settime64()
> function with timespec64 type. We also convert the cap_settime() helper
> function to use the 64bit types.
>
> Move the security_settime() to the head file as a inline function for
> removing that inline helper when following up patches are fixed the
> call sites.
>
> None of the existing hooks is using the timespec argument and therefor
> the patch is not doing any functional changes.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Reviewed-by: James Morris <james.l.morris@oracle.com>
next prev parent reply other threads:[~2015-07-30 8:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 1:44 [PATCH v2 0/5] Introduce 64bit accessors and structures required to address y2038 issues in the posix_clock subsystem Baolin Wang
2015-07-29 11:58 ` [PATCH v2 1/5] time: Introduce struct itimerspec64 Baolin Wang
2015-07-29 12:09 ` [PATCH v2 2/5] timekeeping: Introduce current_kernel_time64() Baolin Wang
2015-07-29 12:13 ` [PATCH v2 3/5] security: Introduce security_settime64() Baolin Wang
2015-07-30 8:23 ` James Morris [this message]
2016-04-18 16:01 ` [RESEND PATCH " Arnd Bergmann
2016-04-18 16:31 ` Mark Brown
2016-04-19 1:57 ` Baolin Wang
2016-04-18 16:54 ` John Stultz
2016-04-18 17:04 ` Kees Cook
2016-04-19 19:59 ` Serge E. Hallyn
2016-04-19 2:02 ` Baolin Wang
2015-07-29 12:16 ` [PATCH v2 4/5] time: Introduce do_sys_settimeofday64() Baolin Wang
2015-07-29 12:18 ` [PATCH v2 5/5] time: Introduce timespec64_to_jiffies()/jiffies_to_timespec64() Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.20.1507301822080.4374@namei.org \
--to=jmorris@namei.org \
--cc=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=casey@schaufler-ca.com \
--cc=edumazet@google.com \
--cc=james.l.morris@oracle.com \
--cc=jlayton@primarydata.com \
--cc=john.johansen@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=neilb@suse.de \
--cc=paul@paul-moore.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=sds@tycho.nsa.gov \
--cc=serge.hallyn@canonical.com \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®