From: James Morris <jmorris@namei.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: John Johansen <john.johansen@canonical.com>,
linux-security-module@vger.kernel.org,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] apparmor: clarify CRYPTO dependency
Date: Thu, 22 Oct 2015 10:47:04 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LRH.2.20.1510221046491.16831@namei.org> (raw)
In-Reply-To: <5026142.BskI2YQ2fk@wuerfel>
On Wed, 21 Oct 2015, Arnd Bergmann wrote:
> The crypto framework can be built as a loadable module, but the
> apparmor hash code can only be built-in, which then causes a
> link error:
>
> security/built-in.o: In function `aa_calc_profile_hash':
> integrity_audit.c:(.text+0x21610): undefined reference to `crypto_shash_update'
> security/built-in.o: In function `init_profile_hash':
> integrity_audit.c:(.init.text+0xb4c): undefined reference to `crypto_alloc_shash'
>
> This changes Apparmor to use 'select CRYPTO' like a lot of other
> subsystems do.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2015-10-21 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 19:16 Arnd Bergmann
2015-10-21 20:26 ` John Johansen
2015-10-21 23:47 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.20.1510221046491.16831@namei.org \
--to=jmorris@namei.org \
--cc=arnd@arndb.de \
--cc=james.l.morris@oracle.com \
--cc=john.johansen@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®