From: Meelis Roos <mroos@linux.ee>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] signal: move the "sig < SIGRTMIN" check into siginmask(sig)
Date: Wed, 18 May 2016 21:30:57 +0300 (EEST) [thread overview]
Message-ID: <alpine.LRH.2.20.1605181808140.20591@math.ut.ee> (raw)
In-Reply-To: <20160517195052.GA15187@redhat.com>
> All the users of siginmask() must ensure that sig < SIGRTMIN. sig_fatal()
> doesn't and this is wrong:
>
> [ 211.406327] UBSAN: Undefined behaviour in kernel/signal.c:911:6
> [ 211.406365] shift exponent 32 is too large for 32-bit type 'long unsigned int'
>
> the patch doesn't add the neccesary check to sig_fatal(), it moves the
> check into siginmask() and updates other callers.
>
> Reported-by: Meelis Roos <mroos@linux.ee>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Tested on the same AthlonMP, on HP Proliant DL360G3 and PowerMac G4,
successfully - system still works, warnings are gone.
--
Meelis Roos (mroos@linux.ee)
prev parent reply other threads:[~2016-05-18 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 19:50 Oleg Nesterov
2016-05-18 18:30 ` Meelis Roos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.20.1605181808140.20591@math.ut.ee \
--to=mroos@linux.ee \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®