From: James Morris <jmorris@namei.org>
To: Tyler Hicks <tyhicks@canonical.com>
Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org
Subject: Re: [PATCH RESEND 2/2] net: Use ns_capable_noaudit() when determining net sysctl permissions
Date: Mon, 6 Jun 2016 19:51:42 +1000 (AEST) [thread overview]
Message-ID: <alpine.LRH.2.20.1606061951210.2346@namei.org> (raw)
In-Reply-To: <1464929002-6624-3-git-send-email-tyhicks@canonical.com>
On Thu, 2 Jun 2016, Tyler Hicks wrote:
> The capability check should not be audited since it is only being used
> to determine the inode permissions. A failed check does not indicate a
> violation of security policy but, when an LSM is enabled, a denial audit
> message was being generated.
>
> The denial audit message caused confusion for some application authors
> because root-running Go applications always triggered the denial. To
> prevent this confusion, the capability check in net_ctl_permissions() is
> switched to the noaudit variant.
>
> BugLink: https://launchpad.net/bugs/1465724
>
> Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
> Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
Both applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2016-06-06 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 4:43 [PATCH RESEND 0/2] Quiet noisy LSM denial when accessing net sysctl Tyler Hicks
2016-06-03 4:43 ` [PATCH RESEND 1/2] kernel: Add noaudit variant of ns_capable() Tyler Hicks
2016-06-03 4:43 ` [PATCH RESEND 2/2] net: Use ns_capable_noaudit() when determining net sysctl permissions Tyler Hicks
2016-06-06 9:51 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.20.1606061951210.2346@namei.org \
--to=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tyhicks@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®