From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757434AbcHWKRe (ORCPT ); Tue, 23 Aug 2016 06:17:34 -0400 Received: from smtp1.it.da.ut.ee ([193.40.5.66]:35681 "EHLO smtp1.it.da.ut.ee" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757089AbcHWKRd (ORCPT ); Tue, 23 Aug 2016 06:17:33 -0400 Date: Tue, 23 Aug 2016 14:46:15 +0300 (EEST) From: Meelis Roos To: Chris Wilson cc: Linux Kernel list , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: Re: i865, drm_modeset_lock_all: BUG: unable to handle kernel NULL pointer dereference at 00000104 In-Reply-To: <20160823101054.GG20834@nuc-i3427.alporthouse.com> Message-ID: References: <20160823091151.GE20834@nuc-i3427.alporthouse.com> <20160823101054.GG20834@nuc-i3427.alporthouse.com> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > Looks like an incorrect call to drm_encoder_cleanup() from the error > > > path. If we hit the error path we have never called drm_encoder_init. > > > Please try: > > > > > > diff --git a/drivers/gpu/drm/i915/intel_dvo.c b/drivers/gpu/drm/i915/intel_dvo.c > > > index 47bdf9dad0d3..b9e5a63a7c9e 100644 > > > --- a/drivers/gpu/drm/i915/intel_dvo.c > > > +++ b/drivers/gpu/drm/i915/intel_dvo.c > > > @@ -554,7 +554,6 @@ void intel_dvo_init(struct drm_device *dev) > > > return; > > > } > > > > > > - drm_encoder_cleanup(&intel_encoder->base); > > > kfree(intel_dvo); > > > kfree(intel_connector); > > > } > > > > It works - the BUG is gone. > > > > Now I get just > > [drm:__intel_set_cpu_fifo_underrun_reporting [i915]] *ERROR* pipe A underrun > > Other than the annoying underrun, is everything else as expected? i.e. > no connected outputs? Have we lost dvo detection? Yes, as expected - there is no monitor connected. -- Meelis Roos (mroos@linux.ee)