From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751416AbdA3AmT (ORCPT ); Sun, 29 Jan 2017 19:42:19 -0500 Received: from namei.org ([65.99.196.166]:34056 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbdA3AmJ (ORCPT ); Sun, 29 Jan 2017 19:42:09 -0500 Date: Mon, 30 Jan 2017 10:43:31 +1100 (AEDT) From: James Morris To: Mimi Zohar cc: SF Markus Elfring , linux-ima-devel@lists.sourceforge.net, linux-ima-user@lists.sourceforge.net, linux-security-module@vger.kernel.org, Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/3] ima_fs: Move three error code assignments in ima_write_policy() In-Reply-To: <1485520764.2596.89.camel@linux.vnet.ibm.com> Message-ID: References: <1485520764.2596.89.camel@linux.vnet.ibm.com> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Jan 2017, Mimi Zohar wrote: > On Wed, 2017-01-25 at 10:34 +0100, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Tue, 24 Jan 2017 22:47:07 +0100 > > > > A local variable was set to an error code in three cases before a concrete > > error situation was detected. Thus move the corresponding assignments into > > if branches to indicate a software failure there. > > > > This issue was detected by using the Coccinelle software. > > This coding style was pretty common. I assume the compiler is smart > enough to do the right thing. Is this a FYI, letting us know for the > future the preferred coding style, or are we really upstreaming these > sorts of coding style changes? Nope, and I generally don't want cleanup patches from Markus going into the security tree. See also: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1254425.html - James -- James Morris