mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Morris <jmorris@namei.org>
To: Matt Brown <matt@nmatt.com>
Cc: serge@hallyn.com, gregkh@linuxfoundation.org, jslaby@suse.com,
	akpm@linux-foundation.org, jannh@google.com,
	keescook@chromium.org, kernel-hardening@lists.openwall.com,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make TIOCSTI ioctl require CAP_SYS_ADMIN
Date: Wed, 19 Apr 2017 21:18:13 +1000 (AEST)	[thread overview]
Message-ID: <alpine.LRH.2.20.1704192114270.12914@namei.org> (raw)
In-Reply-To: <20170419034526.18565-1-matt@nmatt.com>

On Tue, 18 Apr 2017, Matt Brown wrote:

> This patch reproduces GRKERNSEC_HARDEN_TTY functionality from the grsecurity
> project in-kernel.

It seems like an ugly hack to an ugly feature (CAP_SYS_ADMIN barely makes 
sense here), and rather than sprinkling these types of things throughout 
the kernel, I wonder if it might be better to implement it via LSM, in the 
YAMA module.



- James
-- 
James Morris
<jmorris@namei.org>

  parent reply	other threads:[~2017-04-19 11:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19  3:45 Matt Brown
2017-04-19  4:58 ` Serge E. Hallyn
2017-04-19  5:20   ` Kees Cook
2017-04-19 23:43     ` Matt Brown
2017-04-19 23:21   ` Matt Brown
2017-04-19 23:53     ` Serge E. Hallyn
2017-04-20  4:44       ` Matt Brown
2017-04-20 15:19         ` Serge E. Hallyn
2017-04-20 15:24           ` [kernel-hardening] " Serge E. Hallyn
2017-04-20 17:15           ` matt
2017-04-20 17:41             ` Serge E. Hallyn
2017-04-21  5:09               ` Matt Brown
2017-04-21  5:24                 ` Serge E. Hallyn
2017-04-21  6:01                   ` Kees Cook
2017-04-22 17:09                   ` Matt Brown
2017-04-22 19:50                     ` Serge E. Hallyn
2017-04-19 11:18 ` James Morris [this message]
2017-04-20  0:08   ` Matt Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LRH.2.20.1704192114270.12914@namei.org \
    --to=jmorris@namei.org \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jannh@google.com \
    --cc=jslaby@suse.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=matt@nmatt.com \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®