From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752860AbdF2Lqj (ORCPT ); Thu, 29 Jun 2017 07:46:39 -0400 Received: from mail-eopbgr30051.outbound.protection.outlook.com ([40.107.3.51]:49216 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752384AbdF2Lqc (ORCPT ); Thu, 29 Jun 2017 07:46:32 -0400 Authentication-Results: spf=pass (sender IP is 188.184.36.46) smtp.mailfrom=cern.ch; topic.nl; dkim=none (message not signed) header.d=none;topic.nl; dmarc=bestguesspass action=none header.from=cern.ch; Date: Thu, 29 Jun 2017 13:46:09 +0200 From: Tom Levens X-X-Sender: tlevens@lxplus092.cern.ch To: Mike Looijmans CC: Tom Levens , Guenter Roeck , , , , , , Subject: Re: [PATCH v2 3/3] hwmon: ltc2990: support all measurement modes In-Reply-To: <9a6ba152-3d17-3f9c-782c-1f10aa74691b@topic.nl> Message-ID: References: <1479384616-12479-1-git-send-email-tom.levens@cern.ch> <1479384616-12479-3-git-send-email-tom.levens@cern.ch> <410de6c9-a13e-51f7-4d66-6f4e2537c574@roeck-us.net> <97eb089f-e0e2-1146-6e17-8f9f790433d8@topic.nl> <20170628150130.GC30968@roeck-us.net> <20170628160048.GA8915@roeck-us.net> <9a6ba152-3d17-3f9c-782c-1f10aa74691b@topic.nl> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII"; format=flowed X-Originating-IP: [188.184.95.66] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:188.184.36.46;IPV:NLI;CTRY:CH;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39410400002)(39400400002)(39850400002)(39860400002)(39840400002)(39450400003)(2980300002)(438002)(189002)(24454002)(377424004)(252514010)(199003)(4001350100001)(229853002)(86362001)(2906002)(7696004)(53546010)(356003)(7636002)(7736002)(83506001)(5660300001)(189998001)(74482002)(561944003)(66066001)(53416004)(54906002)(3846002)(55016002)(6116002)(110136004)(23726003)(93886004)(47776003)(6666003)(6306002)(305945005)(2950100002)(5005980100005)(4326008)(6916009)(106466001)(8676002)(54356999)(478600001)(8936002)(6246003)(76176999)(50986999)(966005)(50466002)(15974865002)(38730400002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR06MB1630;H:cernmxgwlb4.cern.ch;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;AM5EUR02FT060;1:U+jxU0TQFdsiMuNVA9IrnuSQNcye12GnMiKpoyU/qHrElIwgBEhvUAby0TEIEai11OP8hMPR+VRs/8c9vL2ZAhfgmDSdJbot8WgVkCNhItGVVpQ7k5iJHQPdSwmX12ssuiyEbuVoU4UUmPjCss/ghT88BmAzLRz3iGt2yYPYzIZkpwam/yWPO9PBqgoOBWMER0rKAittgZ6GKWdYXnW2cqf3VutXmq4NsQQ7hSqyemTCJOkY2UMjzCO+OqiGfTlx10hpxsBvQ3eyLhQ/xReRC1j6TQ92+DDjnmce4SfznHmz+8Au454+SAjJBiy0QZu2Te6FYAK5gb5DPGa0+6uSlwFxQUF2LPA7Jw/tjKnHA/mYrk/7+A8HlNjAMbnTbPaGGAYAQ4JZy76jF7SQF3aVe9cWftAJi+HsN70gj0ai87rSyxm/kkdtwofp73KPWk2GjIMP5jo6oiIVtRr/vVnoVop5HWgJHUUVTpnPgOAzLu8btU4GKlO/VmZ5qBHuqvc1dVl0+FBmBrdxbNwescl7OzWLWDqktYybzrS9pbUqyZAoAAcnElrCqCOd4MOTHSWj52VU/JjLTOQZ72YPUAR9aca4F050NwmWARNQbzu/fob0hpLDC0laJcZqoV0Gpi++IAs4Ezc1Z6aFhe1JmJBrfGjssiPcT3DhAFCcbYvfanJIAkQLlVDiz9iKDmjXzBVAG+b+JcaoCCWb1/GGeOi6j5D+S+hM3ESUWQNPoOPQAKs4H6Jy3V/IVzxA6lQqU+KmsR/O3iJYj4biO3szr1P3bgh99U2v3GLvInlagTlLuMZfUBamX2guffVIWdaHnRPHzspsouCh9GOiFWIxonEdIh4lL2h2BC10wfbqKXJRnvWORvlk0cFkVFdpCY8r+950JtKvHzoIDvo9JTTWhmD2qA== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8d28d13c-9ce4-49f8-1da3-08d4bee47a7f X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(8251501002)(2017030254075)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:VI1PR06MB1630; X-Microsoft-Exchange-Diagnostics: 1;VI1PR06MB1630;3:WvEG1mEshVbPmy+QehKGZdNUn+givxeJxMQRqnd9s2tyRoXWZQjTDdyLLPIJJ1vcVEh8sXE+rfvX0CClgtnekD30212pjuU0vIo/4MJLktCsCK1zUzwcsHDfthXDZhTx+8MWQbpOrxWC8I6sPyXHhKQk8M1GJvavN3HrrjFrt7Wah/Lm8qTdzT33vr3EVkh8x09ruPrb1Zzo2hUOwXBeXJ9wya6m8XHAkcBzOghHMuSFzIwIYbyGvAKc1m/JkDTZV2EkmWRShxT/sE9O8w8N0tE8lUOni/ZgdQ0GX3SvXzt1Ypxc7YjVk8mdov0mESWr5fho8PpcWVYmYin/98HpnGeK0Hse98tVAnb13U1jVzE9JA5yNMqlxbPL9JEdDHThMgpEHMQkrnERnYqDsfN/A9/uFjLuLl8SA3nDMY9dGIipyuy3JHJCXiuLYQZgibq3O3n/TiONMZMkzBsRGQi38lXE7DQ8h9yu/4BnkYT7CfY2w2ryehjbSTPfdbMBc/Ra2guWC9bktEmen2l8gft/EuGAMqbTtrpNRqRlNds8xA8yWFUJdV7YRgFjIxGhkIsNe9gCSiGmmJN+FfOb0BksOQk3ajctDVpr+LnhPCYFrLDtRq5+05QPNYYJv91Tj4j+XvMj1rMMJAVPdR3QcUYlSFCVYuU7/5KIkYrZ2NpuwgfpTTA8p1tW720bwqBOCp1WT85yyi299lm1j7AFH4g7J87QrFmZV6jfFx/KfY87nSKSg9VcErj4YT0P3nDf7pUPF4XDhCt2uuGB9NZACZRoZRgalWNXPeugwidsCv4kHoYcIYazLDkogna5TQmJlEVnRzJn51O4pSborAhRybmwRFc0OZJ5laO3Czz3BNOxUlVGeGvc5SGuYm279FnlQmGRSno3aKCeMOUSSzgeO91OqA== X-MS-TrafficTypeDiagnostic: VI1PR06MB1630: X-Microsoft-Exchange-Diagnostics: 1;VI1PR06MB1630;25:gipGYwJI74hpobgavy0vhA7Q5BkSpHJtExkhUCj47OTuJ1CEFhUdkT7MqzZo9CKGFC9n1myfRV+NzDnx7TzRMkhxQMpKMU0XoySBHfiNQhKC6CA8VUhvbJtA0dPNhhf/ma1pvlK0VNmsmFXdvVLq8PHQD3PtNGrjVrUG8Z8kUQuqB56Rc6bVa+4tzteUO9eepBiMRqdapVgWnUbqASME+2pm7EpzUMiRjWtZUmcSlZOxYtw8o6cbHuGhS9GH0pbN3ISiX+rkPI9JkqO3IzDO7jFVHyiKTPnLydeM9U8/poef5jV9DROROp8qGpELqZlUt9mUq1pMCHClf2IdYrdw/qCKRw0OO0W+BI8hFGZwA0cckKK+Zf2GY8Ss9nfSLH5lcJvHo++kELicGFMItjolBT5gzm7MsX1oAZysRoeGrvMyD3L52z4deWjw5yY9y0sN0DnZYEf85CdHbe4l6OzY2G378Gfu500+WctovQb8n+1c8QeDL+BYsTA77VMJsexx5ym8r1ur+/raa5MfwU1TnSfyW9TK3G54hxbMoUEIWYmMMgXaMEHRPX/ZMcB/66bKzPvYIPwVrLndf46yg7p0Ezcbfq7u2NoPm4MJ3BlxapO87ne/fSnv38GWKJ0fmB3rMtYSM9BZqg8ZRXfcFzcq4rTnntZQsMJCJ4UTXgrWoPDhlE1e9pZFziSXPX9BSmSRvNzXmu/5Nte6SJTN49/letJebgcJ4oRtzFSAsLJ8DcwPPVCtNRREin5cDB28LR43f1o0o+e29l1JigUc0/JH0S2lYGnG95Q2URu78tWP160rwG1KMpVHFi24432VarkroGT8d4E1rnhd2znnqd9++GYHbO7RZK6FRNgrWItgJ7GbXoEAg1VJAWsRsMx0t9lrB3Xu4R4ySopm+07x9NGngmtJcq3RSGxnUj4mLLayDr0= X-Microsoft-Exchange-Diagnostics: 1;VI1PR06MB1630;31:0keIFQ0a4pSLvepN1bzsSfbaEJBJlZYieXXzAR8EAN2/HvOZ8Nfii4RayUrxeCPRzmOa2gTj0X2ViQ8p8jjrqf+x2W9jRsYNNeuFe1AzudRyJAQ7P8gg7LbXr2Gbl30O2+yJGFuK8d0q9wxQGKFHPN8Xkdb+kAzH8B2b68cf8FOTBzMLtZE8PXvp2NwPaSZGZf5bSGollSrKBmg/QpQ1O3wJY9iAvE99kvO+ATWp0iOd9EP0Gk/DjA3IZsv4o8ufXog5ElyWLuPC6XDkFoHfUeHMJAVf1wyEPMKBRzjQFDlu8gOsxwzV29+cxonCmIJRUPpC1fuPt/FfXvZw2tXLB/LQN8Hi1APMjISiSPvLj3EZPoocXGGZC27antkYcx48khPGV9DmZOWw+i+Hy3BJY5tfMmh/v9I3Vvo8c0rp/nB4Z+rh5zDlTfCim/3+9gY5UuvEpL9jI/hRe9WOgxrI4z8WTNRLB2wweNnDzLc8eF3FUWdACWp9MlG+QQjFjOoNimlexwp0et/XUK+b48IUNKzgZXIT+9Yuyiq+uw6j2NYkoCThOcFFNIBLVojVctxgpg/7vYbCMRtifhm4XMRLjaGFqjBXb2QCOZ+2eRShWK7TRVkMOsjffcWOnH29l8C7w8moJdt8bBE2x0EOuOvRtFXmf2JdLRbUWrqHaiX6V4sSNX7teAyh2mUNNTbChQuLZpYts9QoCGIWJ1K/1g4UcQ== X-Microsoft-Exchange-Diagnostics: 1;VI1PR06MB1630;20:a2nlQosh+znUDFTKCkdHQauaI7aIz9d/BbNc+6vPRhTz0MXTcneXeUwZ5GggLinWBu+sI0XrT2GxTSSECZ+HVXSM6lCnjr1YfZLP+3soXkbtJJVM3gEgtCYFwiMKlyS5iuQXog221N9iM5wyBpEv2WOnWWcQRqI56Qif8PGuxlj0ic3Iaxsh5NEGY1mKGjN9T3AbJcJYLtaP/3TFnZzkFxDzeMl7/ZFTmjFyDsIJ8wGDYQRZ72w89sorwC40yHB5y7LJvElmRzMwNioxcfkZc3eDEAf4j5EASkK1WtpmswQf2kMJwTfMAtpBbhjPb8Y/u/RXVPcuXwspCiDlJX9bo38D4vbPhSwU68xGCIF9qx12sG8wyMgqLH+D3vW9uh+J75KTPrGhZ7pGJCENCSOFL+CuD4xRdQ49/ooJ21lr9Daezbr0OhDUtkW1HC8TGtJrO0IbaoFHHdqolZQF4YqJ8TmMKK6S5vGR5mXI+OG2Dd1t4gQJ2jeC68JS/C315ZnM X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(133145235818549)(166708455590820)(236129657087228)(48057245064654)(5213294742642)(247924648384137); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(13016025)(13018025)(3002001)(93006095)(93004095)(100000703101)(100105400095)(10201501046)(6041248)(20161123564025)(20161123562025)(201703131423075)(201702281529075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR06MB1630;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR06MB1630; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR06MB1630;4:GULewuysMMQLBCMQEheogJRMC+tJlAJfEbgPwWf6on?= =?us-ascii?Q?dK1LCDauvbaCD92CNJrxS4q10a6lTcLxx31UKcdI7pKVx2M4qQfGrC43Cfmb?= =?us-ascii?Q?kZd6Zaw8oPlhWqplQdyF/flt3f9OcqSMGBP6vIVHp4b3AVx33n5xgEaut7xv?= =?us-ascii?Q?zOoW+kEJEqgtmS+wLZyk1UEpr5fEfYpTf8E8R8iL/wZK+pVyTxV8up9QolEx?= =?us-ascii?Q?zFzu8ApwAFzixuxx4Iv6hbrsGGgq5S9PlST75zxJ5vFuC/YSmcWoiSXaYi6H?= =?us-ascii?Q?yE+4rQddZJ+lDJzN/rW7AxwekJ12lWdXupV8EIr28skqZhoWFue6sw1IRZY1?= =?us-ascii?Q?frKWEDopGA8Ev0PjpAc+XWPmMrzN1SlWRfCua6KsohgpgSqXeOZmwaIJBas6?= =?us-ascii?Q?GE5faryVZ0jij3890wtA1b7Uv6fK1HZJ26WQey2COZKajDsCBiCcBh7HJnE/?= =?us-ascii?Q?Nn/zskXhL9Ok/sKnbp+liK0Uj3bh/ZUy5ETcVNUV7hRTTzGQCkqWAX5S8ycI?= =?us-ascii?Q?xG8ZcMxxcBJCL5EWRYsckBO4ky1x2H/StdT9Hs829j1yd+O1ZREeFhetpxYe?= =?us-ascii?Q?m9Q34yxd73hubl8nxoS8OPZrJLPdH0baJe6IH1zq5jlsK9M7nh0UUBeTawGw?= =?us-ascii?Q?E+DaHRZzenBlKknMg9VCi/fNhfrs7GAGf7uvqTGUNBxTy8TD3cCglH86G0M+?= =?us-ascii?Q?oYFOQ/SC6s84K1WrjX3laZmTmmDav0RMPByQbu8ivY+29cCqc9AJsu8057+c?= =?us-ascii?Q?nKhhsDlB/+eXcsu9Y7nNrQTxaJnLe4NY3943yo0W5gkGTkDHPv236kmcnSXD?= =?us-ascii?Q?pe0LQc76/1najBWIP0kzMy9TvjlRABt77MpSiTPITb6xvb1lpst8breDkOB4?= =?us-ascii?Q?DrWHJsH3b0OmBG3/D2hepFtmrqtkCsVt/RJnc/EL8s3UnphuvlH9L6UsmDzb?= =?us-ascii?Q?420T0J7dleVORWO1HmX6IvbOlxbyg25vlgtaHocu9fX+w3bikaDVitClI5uR?= =?us-ascii?Q?2T+A6throkoE4kSRMJ3Ur4Dwr7fNEuOj4zQp6pu4k+Fh7i9ASIQ6RLxZgGkw?= =?us-ascii?Q?I93LynN+hqK1JKFlPEfyGrEQz+jq25yBXSSubzYBriQNZrXv0/6ElFki1bep?= =?us-ascii?Q?5OxqZl3fvr3m/lQsl/A8rXyaEO9PDNbAljdousQrT9cxNF+8fI5aLwD/mJeg?= =?us-ascii?Q?LHxFyRUlV71D9eRB7kQYqwpRbzqnFZK994mGkxQZ/XIyIipXsgB39vDmYxee?= =?us-ascii?Q?qlpTDNwL3Anr/V7maBUQgYxWysFDN7dLdcJiu9GQESx/IMmk86Ss1P417QTs?= =?us-ascii?Q?YFruiAPdv/vW2+Z7DVajv6C0DjAW9DsWc2xg/AdtlwSgP13AVE/pxkcG5TJJ?= =?us-ascii?Q?2GjYyVJOToayfQKwlYeM5B77HdTGFpwUbTQ4B77wKXkrmxARJj+CBnJdsQm3?= =?us-ascii?Q?ojIT5pox5DpeMGUmiwa+yBPj0+wJQ=3D?= X-Forefront-PRVS: 0353563E2B X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR06MB1630;23:JIvZTxppJ7CN9zerMBjcZXU1oO/nCAszMSld+4yAZ?= =?us-ascii?Q?TzfM3ANa9b6GNuV02bzmTQJ5z9BVJUFPNK7d2j2hLZz1KWhcREwdYeJw9nod?= =?us-ascii?Q?zCLUEq6/F0XD+5Js/lF5tcoeuXrhxNsIy1u4uOv0LvzWMPpFEnzy2bfKRIqf?= =?us-ascii?Q?ZabN7Xv28u8XiIexHi5wE+6jnNghicPQy2CuvaRmTc8KZy4v5OfTKMNZ8IEv?= =?us-ascii?Q?vFmgx/MCdQtoY9dta2mzYe/tKjBXt4HOUd4s/P7ryEVpaDCGMZmesfOifVxd?= =?us-ascii?Q?3NP9CFYjM2ZyoA7pcea7C0Z1MGtIcOSCJkHAq68ZK7YSIPaTJW6NCvKQth2E?= =?us-ascii?Q?sk4AJs/DCeooZ9vxUo+owL+J+n5qeVS6rG6uHLwJa50RBvXRBvmGSdbHTdPa?= =?us-ascii?Q?nCQ7s1op/efhwMAS1xnHA8pD0EI073V4AUjT6qlA1/9q5btbxSrHpouyYmhw?= =?us-ascii?Q?mmW1L7FoLgC3ooMovTo8yZ6fX78eRIuFwAHJrPyUsurv6f3RcEFhyDIgInh1?= =?us-ascii?Q?2Tc5n1Slqg/tD1HM31KlpQaHZ2Wyd681phXPZzKjUhXR+RqIn3axFSRI83cO?= =?us-ascii?Q?C6C0r+vM3ncCZ8giE1wQZUN1N1s58AKkV3EyPHL5zQWgmd25dJNKZOgPYgi0?= =?us-ascii?Q?27Iaqr/rouZjbD5ClQqeXIU/G9QKqcylPJ1ORKZNJY9AyUr5SIjJosFxpsxl?= =?us-ascii?Q?WD6RzrBmus7zkBegXUDXxdCQfO7fakTniNNjIAf4Io9DlY9AZQlAHNONLc3q?= =?us-ascii?Q?keYryqVsqy6yLn27MUTh8sNSQQTEt7W1usUnu3ocwkedzs5PvwmNaWm9aYFQ?= =?us-ascii?Q?xSOWZn4GPo8x4MzLRria5zsuU+/0xzRozgUQN4yJ3AQZA5qEKnZlEaKmCbQ3?= =?us-ascii?Q?ABvtPDDZ6hcYMN3fIhfq3Ux5Qp2xMlAr4gNBsg3Av8Q6qWYNcR/LRW91X10M?= =?us-ascii?Q?gnVy1pNd1QVsc3TrQmFTYFqQ23QtGzRKisuvq0ZuZWzQjs/P7NglNEAjiuwH?= =?us-ascii?Q?ubrzcmewJfDrM79XQ3ujU3B4/z/EBK5gJhzX7XXojgIBHQ529HeFtgBVk7io?= =?us-ascii?Q?BM7HwsTQa/RNVrmVDcgAxQlmllMDLXbhrCyRAWxXS2EdFppOGzu/bfFLvQsB?= =?us-ascii?Q?cAXyuHG5i/nBQBcyrZAXm1YcH901DDAGdsvo8EwrCDrC9V1BsZbUdvtr5UJD?= =?us-ascii?Q?V3RoRIjNyVJMx7FQKNKp1z/ZarkU0Hu3YGx1Q9zkEf5WnugT0pQTf5PpvPBj?= =?us-ascii?Q?ejfwPjiqWrPX+oOhdG/t2sj0S+Hir9Wss5hqIE7CYpht2LZ9uBzHCeZk3aj3?= =?us-ascii?Q?HtcjV/XlILpsA28O1xwneHnSADY6cEAOqjwOSTnETuNjg8MTMDDKHIeTiukZ?= =?us-ascii?Q?EKku55iUNaFYdRamJuXyFajNoY=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR06MB1630;6:FESNp2x71Be/bT1vHtMGEkm3rtGyn14RPCIv4V/la0?= =?us-ascii?Q?pjvQ5ySS8Ki6drP6AkSHqwyINv3jX0E4zEABspJXDN28RY2/qZEIhD5Cti+K?= =?us-ascii?Q?ayOC0c0pZuk1qlEu6ngTk/xtNe4n8SoY7JrwsiewTEX9wo63kZiMLAgAjDPx?= =?us-ascii?Q?cVkP78t+KHXqKepMtPWDfkMhrSTlefYFOVMoo50tkWGQgMCM07ERMjTbUoB6?= =?us-ascii?Q?Kw7tcTfPCuPtBI9oFD+i/9ms51sPsWbcn4lt0Wml3wPB31Y1FaZBH4ec9G0b?= =?us-ascii?Q?9gVr2xSsHsrvzdSmX/DfHGY4qHqD2n9rdXzD/mE9r8FKtvIA5PY5Ix2GYvZ0?= =?us-ascii?Q?6tNfSHQ84OLENdA4IIQTKJlwCD3zk3lWCbgnuMUeixW5UvoZZKabjIEza+4r?= =?us-ascii?Q?VMvE+3jlUAV9CmoUHMhqsBdBR7VGKaEVKdMqg02fdteNsWT16yT1SUKJADgm?= =?us-ascii?Q?rwGryOqR3dCUJrxvpIbtxawRicu/euDLFmOFbyaFzhD4NDZMW/A/3R/0dv+v?= =?us-ascii?Q?0Ing5b8qml9UyQFwTojPpufzo3seaoPp/sMM6enrszOHa9kn19QeNH2RUnA7?= =?us-ascii?Q?J4CpNWXFLYyKNffEPxNCwNWAXPiOYsnW+uG8TqSEPL/bf4r2gSewTbQtvLHN?= =?us-ascii?Q?RtL6QT8SgYAQxK0dmmbc/aRy1GH3/kR8kG2OdjRRRRzBedkycNfEuiYaYNdd?= =?us-ascii?Q?1D7s2oplBE6fpYqzHkKmNTeN6GbeQUs1dVvwzS/rkWurQH8MuQYo7i2NISVH?= =?us-ascii?Q?3CxtUeI89muGoWLHs7HUYDPMPqEm1Y56SQCC2MgabDeKqjWkWZ1741d6QfcK?= =?us-ascii?Q?qHzzI+wmcmMkxQF6ZLxMfJMptLMZGLUmsL9xNp97ckiV8trdOrD3I8+y9CWG?= =?us-ascii?Q?rmEfGVzmOGzpPHfPB9ZQz/TvVJ2Z7YRvuGh13OBKRx98eGa5bQH0yT6KPjAD?= =?us-ascii?Q?hsu8/l9GfX9yL/o4l6oBtx8F7TLdyfhlke8KxNoh0qMlcYjhPKgPndMD7UBQ?= =?us-ascii?Q?k=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR06MB1630;5:VALvGTr2JNlwV/1OlM/IrKPyAyRo6VCSvEZegf/+798CeAWRHTY/2ek7yLea9KNApor/P3pQ2Z01QOeF7oAKH3bc1feFye4jk7H3IPiS3kYn5uDme8aKQeWGU4UL6X+CMeYk7Uw1iHs8tisFMmT8HEFQ2c+CIzgmU+0NSObNGb/LA5aq5tEPcgqS9Vp3XmrZWWmFM1k7YkW3J8WkmGc623g0xCjRLJumqc3apO7WdifjuWvp+JQO4k+wvD34uedrxMRouzcmh4oamC8qVbEFIYHLenieXlzBnWRcw0/tcFsoQrAXeQwXbVKuDjCgEa1dbHog/rTCdTuDxHp98gr4qMunR9djXaaC+SKobCR4W5yBCwGhwIgA0HNny9vocYcKbf2wivwn4Ef3CNFgF15+yfqR+wBp3mKY7XGZ3uFmIqK5+JV36Bo0esiXRf+pEfJtY8CwsCUndRZVJgwHqrFWGcYkUud/+NWv6uFbBh/7Ttk6F0iysfsU4yQFNEn69JSl;24:OLBBx/63bCwf9wqWB51tGcf20p5wuNKDGQmcQg+p3yT07ALBzlmNd5k1bTcl0UyaVweo5ETK0Cn3V3MkLDOpySeUoRGl8xUYX4HUYLr9fao= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR06MB1630;7:Bf/eiDsv+lFUfg0dAF+sLIGTgFi+Ekafk8EuloRsypQ1ndp16mE3fKibPjwpwvO8t6dLvAflRd5smb4CXaE7hOok3wqutmW22F7wUAFRIxlLTfr9+4bIoLKyP/B+KDO9GKTkLOHNtaMujNJV4WlodjbjN5YtZ+P5vnTF4JcyKNOWNXil0gtmOBvjSjyHuoh++xd4DWFlo//hATLIvUGdapnVmHHmywyp0hq6Avt28SEEoTP4LiSWqlgcbzoK6P1NrHyexj+eYU67NCYl0lK08ST30Dq3Zv44qRwza5eLhDYQGMVOR+u1A1auzchKVN8vfMlJheF5QYFWsZdyVqAFCMjMvsA8r6aFrLz8LAy/jNW6NUfciMMCCyYBOCI6HuwGgH8/XMuk6f3AnWnQt3PYizFY7QWAoSQiJVVF6W2r4AVUmL4qGTQU4stYJ3jEmQOUTdobklbENMOCib5d2y7eqNXTwXxebtejGLCBts7fUXKAXNffEO5TsOLiih4TI/HbyfdtGw6zeCvMA20mrb4jsBwhr9qHSWU4R8aPC1F8zCULLhQM4jOdnAcQYPMaRTOpBEFHJ9ZCblridCYfrI1NfLHQU9mkFAY2vaVYUG7RFOqXFLmlCR7YulzdXvGuOCcor/ANRUL0PzCEZfgRepsbg09ORLPHMvsENdx2oqlTaaNecJTcBfTFj7O1JVYGhH/aACWhiRiWadiOD+dSOKO2NpI+VTxUJfSPlR6sFd/KGdNM9BWWVq0oFvFovGZd48ilnyZbLV2oCAjly5c5lbIl3r/yGwHSWnI1dqIpVs36btE= X-OriginatorOrg: cern.ch X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2017 11:46:27.8054 (UTC) X-MS-Exchange-CrossTenant-Id: c80d3499-4a40-4a8c-986e-abce017d6b19 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c80d3499-4a40-4a8c-986e-abce017d6b19;Ip=[188.184.36.46];Helo=[cernmxgwlb4.cern.ch] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR06MB1630 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Jun 2017, Mike Looijmans wrote: > On 28-06-17 19:02, Tom Levens wrote: >> >> On Wed, 28 Jun 2017, Guenter Roeck wrote: >> >> > On Wed, Jun 28, 2017 at 05:29:38PM +0200, Tom Levens wrote: >> > > >> > [ ... ] >> > >> > > > >> > > > > Whatever happened to this patch though? It didn't make it to >> > > > > mainline, >> > > > > otherwise I'd have found it sooner... >> > > > > >> > > > I'll have to look it up, but I guess I didn't get an updated >> > > > version. >> > > >> > > As far as I remember I had a working V3 of this patch, but it is >> > > entirely >> > > possible that it was never submitted as I have been busy with other >> > > projects >> > > recently. I'll dig it out and check that it is complete. >> > > >> > FWIW, I don't see it at >> > https://patchwork.kernel.org/project/linux-hwmon/list/?submitter=171225&state=* >> > >> > Maybe you were waiting for a reply from Rob. Either case, it might make >> > sense to only provide valid modes, ie to abstract the mode bits from the >> > hardware, such as >> > >> > 0 - internal temp only >> > 1 - Tr1 >> > 2 - V1 >> > 3 - V1-V2 >> > 4 - Tr2 >> > 5 - V3 >> > 6 - V3-V4 >> > 7 to 14 - per bit 0..2 >> > >> > Guenter >> > >> >> You are right, there was still an open question about how best to handle >> the mode selection in DT. >> >> In the latest version of my patch I have it implemented as an array for >> setting the two values, for example: >> >> lltc,meas-mode = <7 3>; >> >> This sets bits [2..0] = 7 and [4..3] = 3. Of course these could be split >> into two DT properties, but I was unsure what to name them as both fields >> are called "mode" in the datasheet and "mode-43"/"mode-20" (or similar) is >> ugly. >> >> With regards to your proposal, it is not clear to me whether the modes >> which have the same result are exactly equivalent. Does disabling a >> measurement with the mode[4..3] bits really leaves the part in a safe >> state for all possible HW connections? With this doubt in my head, I would >> prefer to keep the option available to the user to select any specific >> mode. But I am open to suggestions. >> >> Mike, if you would like to test it, the latest version of my code is here: >> >> https://github.com/levens/ltc2990/blob/dev/drivers/hwmon/ltc2990.c >> > > I pulled your patches, added two lines to the devicetree and it works fine, > I'm seeing plausible results: > root@topic-miami:/sys/class/hwmon# grep . */* > hwmon0/name:battery-gauge > hwmon0/temp1_input:291700 > hwmon1/in0_input:3258 > hwmon1/in1_input:1824 > hwmon1/in2_input:1916 > hwmon1/in3_input:1512 > hwmon1/in4_input:2066 > hwmon1/name:ltc2990 > hwmon1/temp1_input:28062 > hwmon1/uevent:OF_NAME=ltc2990 > hwmon1/uevent:OF_FULLNAME=/gpios-i2c@50/ltc2990@4c > hwmon1/uevent:OF_COMPATIBLE_0=lltc,ltc2990 > hwmon1/uevent:OF_COMPATIBLE_N=1 > hwmon2/curr1_input:1825 > hwmon2/curr2_input:349 > hwmon2/in0_input:3244 > hwmon2/name:ltc2990 > hwmon2/temp1_input:31500 > hwmon2/uevent:OF_NAME=ltc2990 > hwmon2/uevent:OF_FULLNAME=/gpios-i2c@52/ltc2990@4C > hwmon2/uevent:OF_COMPATIBLE_0=ltc2990 > hwmon2/uevent:OF_COMPATIBLE_N=1 > > > As you can see, two ltc2990 on two busses, one measuring current and one > measuring 4 independent voltages. > > I also like your implementation of the mode setting better, it's much simpler > than mine. And you've solved a bug in the temperature reading as well. Excellent, I am glad it also works for you! In this case, I would propose that I submit the V3 of the patch for further discussion. Thanks, > > Kind regards, > > Mike Looijmans > System Expert > > TOPIC Products > Materiaalweg 4, NL-5681 RJ Best > Postbus 440, NL-5680 AK Best > Telefoon: +31 (0) 499 33 69 79 > E-mail: mike.looijmans@topicproducts.com > Website: www.topicproducts.com > > Please consider the environment before printing this e-mail > > > >