From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751641AbdHVQeB (ORCPT ); Tue, 22 Aug 2017 12:34:01 -0400 Received: from smtp2.it.da.ut.ee ([193.40.5.67]:43852 "EHLO smtp2.it.da.ut.ee" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbdHVQd7 (ORCPT ); Tue, 22 Aug 2017 12:33:59 -0400 Date: Tue, 22 Aug 2017 19:33:55 +0300 (EEST) From: Meelis Roos To: David Miller cc: hch@lst.de, helgaas@kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, qla2xxx-upstream@qlogic.com, Linux Kernel list Subject: Re: 4.13.0-rc4 sparc64: can't allocate MSI-X affinity masks for 2 vectors In-Reply-To: <20170822.093139.473720171751670244.davem@davemloft.net> Message-ID: References: <20170821.133549.1817020810110297960.davem@davemloft.net> <20170822063505.GA6721@lst.de> <20170822.093139.473720171751670244.davem@davemloft.net> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > On Mon, Aug 21, 2017 at 01:35:49PM -0700, David Miller wrote: > >> I ask because the commit log message indicates that this failure is > >> not expected to ever happen on SMP. > > > > I fear my commit message (but not the code) might be wrong. > > irq_create_affinity_masks can return NULL any time we don't have any > > affinity masks. I've already had a discussion about this elsewhere > > with Bjorn, and I suspect we need to kill the warning or move it > > to irq_create_affinity_masks only for genuine failure cases. > > This is a rather large machine with 64 or more cpus and several NUMA > nodes. Why wouldn't there be any affinity masks available? T5120 with 1 slot and 32 threads total. I have not configured any NUM on it is there any reason for that? -- Meelis Roos (mroos@linux.ee)