From: James Morris <jmorris@namei.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
linux-security-module@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
linux-ima-devel@lists.sourceforge.net,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] integrity: replace call to integrity_read_file with kernel version
Date: Fri, 15 Sep 2017 09:21:53 +1000 (AEST) [thread overview]
Message-ID: <alpine.LRH.2.21.1709150920390.21698@namei.org> (raw)
In-Reply-To: <20170914204954.GA27029@infradead.org>
On Thu, 14 Sep 2017, Christoph Hellwig wrote:
> On Fri, Sep 15, 2017 at 06:21:28AM +1000, James Morris wrote:
> > So, to be clear, this patch solves the XFS deadlock using a different
> > approach (to the now reverted integrity_read approach), which Christoph
> > also says is more correct generally. Correct?
>
> No. It is in addition to the previous patches - the patches were
> correct for the IMA interaction with the I/O path. It just turns
> out that the function was also reused for reading certificates
> at initialization time, for which that change was incorrect.
>
> If this series is applied first the integrity_read code is not
> used for that path any more.
Ok. Sorry I hadn't looked at the code in detail at this stage during the
conference and wanting to just revert back to something that Linus can
safely pull before the merge window closes.
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2017-09-14 23:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 2:45 [PATCH 1/2] vfs: constify path argument to kernel_read_file_from_path Mimi Zohar
2017-09-13 2:45 ` [PATCH 2/2] integrity: replace call to integrity_read_file with kernel version Mimi Zohar
2017-09-14 20:21 ` James Morris
2017-09-14 20:49 ` Christoph Hellwig
2017-09-14 21:00 ` James Morris
2017-09-14 23:21 ` James Morris [this message]
2017-09-13 16:33 ` [PATCH 1/2] vfs: constify path argument to kernel_read_file_from_path Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1709150920390.21698@namei.org \
--to=jmorris@namei.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®