From: James Morris <jmorris@namei.org>
To: David Howells <dhowells@redhat.com>
Cc: Eric Biggers <ebiggers@google.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Michael Halcrow <mhalcrow@google.com>,
keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] KEYS: Fixes and crypto fixes
Date: Thu, 28 Sep 2017 09:14:58 +1000 (AEST) [thread overview]
Message-ID: <alpine.LRH.2.21.1709280912400.12069@namei.org> (raw)
In-Reply-To: <28036.1506547164@warthog.procyon.org.uk>
On Wed, 27 Sep 2017, David Howells wrote:
> (2) Fixing big_key to use safe crypto from Jason A. Donenfeld.
>
I'm concerned about the lack of crypto review mentioned by Jason -- I
wonder if we can get this rewrite any more review from crypto folk.
Also, are there any tests for this code? If not, it would be good to make
some.
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2017-09-27 23:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 21:19 David Howells
2017-09-27 23:14 ` James Morris [this message]
2017-09-28 0:15 ` Eric Biggers
2017-09-28 2:08 ` James Morris
2017-09-28 10:34 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1709280912400.12069@namei.org \
--to=jmorris@namei.org \
--cc=Jason@zx2c4.com \
--cc=dhowells@redhat.com \
--cc=ebiggers@google.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mhalcrow@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®