From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A41CFC4321D for ; Thu, 23 Aug 2018 16:48:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 552332098B for ; Thu, 23 Aug 2018 16:48:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 552332098B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=namei.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726481AbeHWUTU (ORCPT ); Thu, 23 Aug 2018 16:19:20 -0400 Received: from namei.org ([65.99.196.166]:44088 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbeHWUTT (ORCPT ); Thu, 23 Aug 2018 16:19:19 -0400 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id w7NGmdfp011040; Thu, 23 Aug 2018 16:48:39 GMT Date: Fri, 24 Aug 2018 02:48:39 +1000 (AEST) From: James Morris To: "Serge E. Hallyn" cc: Christian Brauner , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] security/capabilities: remove check for -EINVAL In-Reply-To: <20180822135825.GA7223@mail.hallyn.com> Message-ID: References: <20180822115240.18196-1-christian@brauner.io> <20180822135825.GA7223@mail.hallyn.com> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Aug 2018, Serge E. Hallyn wrote: > Quoting Christian Brauner (christian@brauner.io): > > bprm_caps_from_vfs_caps() never returned -EINVAL so remove the > > rc == -EINVAL check. > > > > Signed-off-by: Christian Brauner > > Thanks. > > Reviewed-by: Serge Hallyn Thanks, I'll queue this for post -rc1 next-general. -- James Morris