From: Meelis Roos <mroos@linux.ee>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] kconfig: do not require pkg-config on make {menu,n}config
Date: Fri, 31 Aug 2018 13:26:04 +0300 (EEST) [thread overview]
Message-ID: <alpine.LRH.2.21.1808311325260.31140@math.ut.ee> (raw)
In-Reply-To: <1535708095-15847-1-git-send-email-yamada.masahiro@socionext.com>
> Meelis Roos reported a {menu,n}config regression:
>
> "I have libncurses devel package installed in the default system
> location (as do 99%+ on actual developers probably) and in this
> case, pkg-config is useless. pkg-config is needed only when
> libraries and headers are installed in non-default locations but
> it is bad to require installation of pkg-config on all the machines
> where make menuconfig would be possibly run."
>
> For {menu,n}config, do not use pkg-config if it is not installed.
> For {g,x}config, keep checking pkg-config since we really rely on it
> for finding the installation paths of the required packages.
>
> Fixes: 4ab3b80159d4 ("kconfig: check for pkg-config on make {menu,n,g,x}config")
> Reported-by: Meelis Roos <mroos@linux.ee>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Tested-by: Meelis Roos <mroos@linux.ee>
--
Meelis Roos (mroos@linux.ee)
next prev parent reply other threads:[~2018-08-31 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 9:34 Masahiro Yamada
2018-08-31 10:26 ` Meelis Roos [this message]
2018-08-31 22:21 ` Randy Dunlap
2018-09-03 0:37 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1808311325260.31140@math.ut.ee \
--to=mroos@linux.ee \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome