From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA91DECE561 for ; Sat, 22 Sep 2018 09:49:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F3FA21532 for ; Sat, 22 Sep 2018 09:49:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F3FA21532 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.ee Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728175AbeIVPmJ (ORCPT ); Sat, 22 Sep 2018 11:42:09 -0400 Received: from smtp1.it.da.ut.ee ([193.40.5.66]:46996 "EHLO smtp1.it.da.ut.ee" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726363AbeIVPmJ (ORCPT ); Sat, 22 Sep 2018 11:42:09 -0400 Received: from math.ut.ee (unknown [IPv6:2001:bb8:2002:2400:5054:ff:fe3b:8db9]) by smtp1.it.da.ut.ee (Postfix) with ESMTP id DB2A790018; Sat, 22 Sep 2018 12:49:08 +0300 (EEST) Received: by math.ut.ee (Postfix, from userid 1014) id AF779220B5E; Sat, 22 Sep 2018 12:49:06 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by math.ut.ee (Postfix) with ESMTP id B7818220413; Sat, 22 Sep 2018 12:49:06 +0300 (EEST) Date: Sat, 22 Sep 2018 12:49:06 +0300 (EEST) From: Meelis Roos To: Joel Stanley cc: Krzysztof Kozlowski , Greg Kroah-Hartman , Herbert Xu , Michael Ellerman , Christophe LEROY , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib/xz: Put CRC32_POLY_LE in xz_private.h In-Reply-To: <20180921025431.28366-1-joel@jms.id.au> Message-ID: References: <20180921025431.28366-1-joel@jms.id.au> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > This fixes a regression introduced by faa16bc404d72a5 ("lib: Use > existing define with polynomial"). > > The cleanup added a dependency on include/linux, which broke the PowerPC > boot wrapper/decompresser when KERNEL_XZ is enabled: > > BOOTCC arch/powerpc/boot/decompress.o > In file included from arch/powerpc/boot/../../../lib/decompress_unxz.c:233, > from arch/powerpc/boot/decompress.c:42: > arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:10: fatal error: > linux/crc32poly.h: No such file or directory > #include > ^~~~~~~~~~~~~~~~~~~ > > The powerpc decompresser is a hairy corner of the kernel. Even while building > a 64-bit kernel it needs to build a 32-bit binary and therefore avoid including > files from include/linux. > > This allows users of the xz library to avoid including headers from > 'include/linux/' while still achieving the cleanup of the magic number. > > Fixes: faa16bc404d72a5 ("lib: Use existing define with polynomial") > Reported-by: Meelis Roos > Reported-by: kbuild test robot > Suggested-by: Christophe LEROY > Signed-off-by: Joel Stanley Tested-by: Meelis Roos -- Meelis Roos (mroos@linux.ee)