From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5240ECE562 for ; Fri, 28 Sep 2018 17:00:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A55E420676 for ; Fri, 28 Sep 2018 16:53:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A55E420676 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=namei.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729298AbeI1XSb (ORCPT ); Fri, 28 Sep 2018 19:18:31 -0400 Received: from namei.org ([65.99.196.166]:34028 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726473AbeI1XSb (ORCPT ); Fri, 28 Sep 2018 19:18:31 -0400 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id w8SGrQD2017225; Fri, 28 Sep 2018 16:53:26 GMT Date: Sat, 29 Sep 2018 02:53:26 +1000 (AEST) From: James Morris To: David Howells cc: Randy Dunlap , Lubomir Rintel , Mat Martineau , Stephan Mueller , Andrew Morton , Linus Torvalds , stable@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, Lubomir Rintel , Randy Dunlap , linux-kernel@vger.kernel.org Subject: Re: [PATCH] keys: Fix the use of the C++ keyword "private" in uapi/linux/keyctl.h In-Reply-To: <153809228025.23030.6619415372705612845.stgit@warthog.procyon.org.uk> Message-ID: References: <153809228025.23030.6619415372705612845.stgit@warthog.procyon.org.uk> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Sep 2018, David Howells wrote: > The keyctl_dh_params struct in uapi/linux/keyctl.h contains the symbol > "private" which means that the header file will cause compilation failure > if #included in to a C++ program. Further, the patch that added the same > struct to the keyutils package named the symbol "priv", not "private". Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general and next-testing. -- James Morris