From: James Morris <jmorris@namei.org>
To: Kangjie Lu <kjlu@umn.edu>
Cc: pakki001@umn.edu, "Serge E. Hallyn" <serge@hallyn.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [PATCH] security: inode: fix a missing check for securityfs_create_file
Date: Sat, 16 Mar 2019 06:08:43 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LRH.2.21.1903160608080.2905@namei.org> (raw)
In-Reply-To: <20190315040901.31551-1-kjlu@umn.edu>
On Thu, 14 Mar 2019, Kangjie Lu wrote:
> securityfs_create_file may fail. The fix checks its status and
> returns EFAULT upstream if it fails.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> security/inode.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/security/inode.c b/security/inode.c
> index b7772a9b315e..11d9a6bc2161 100644
> --- a/security/inode.c
> +++ b/security/inode.c
> @@ -339,6 +339,11 @@ static int __init securityfs_init(void)
> #ifdef CONFIG_SECURITY
> lsm_dentry = securityfs_create_file("lsm", 0444, NULL, NULL,
> &lsm_ops);
> + if (IS_ERR(lsm_dentry)) {
> + unregister_filesystem(&fs_type);
> + sysfs_remove_mount_point(kernel_kobj, "security");
> + return -EFAULT;
> + }
> #endif
> return 0;
> }
>
Good catch, but you should propagate the error returned from
securityfs_create_file().
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2019-03-15 19:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 4:09 Kangjie Lu
2019-03-15 19:08 ` James Morris [this message]
2019-03-15 21:00 ` Kangjie Lu
2019-03-15 22:34 ` Tetsuo Handa
2019-04-10 17:34 ` James Morris
2019-04-10 18:01 ` Al Viro
2019-04-10 22:00 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1903160608080.2905@namei.org \
--to=jmorris@namei.org \
--cc=casey@schaufler-ca.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®