From: David Kozub <zub@linux.fjfi.cvut.cz>
To: Scott Bauer <sbauer@plzdonthack.me>
Cc: Jens Axboe <axboe@kernel.dk>,
Jonathan Derrick <jonathan.derrick@intel.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Subject: Re: [PATCH 0/3] block: sed-opal: add support for shadow MBR done flag and write
Date: Thu, 2 May 2019 18:03:23 +0200 (CEST) [thread overview]
Message-ID: <alpine.LRH.2.21.1905021749060.929@linux.fjfi.cvut.cz> (raw)
In-Reply-To: <20190502123036.GA4657@hacktheplanet>
On Thu, 2 May 2019, Scott Bauer wrote:
> On Wed, May 01, 2019 at 01:20:56AM +0200, David Kozub wrote:
>>
>> Jonas Rabenstein (3):
>> block: sed-opal: add ioctl for done-mark of shadow mbr
>> block: sed-opal: ioctl for writing to shadow mbr
>> block: sed-opal: check size of shadow mbr
>>
>> block/opal_proto.h | 16 ++++
>> block/sed-opal.c | 160 +++++++++++++++++++++++++++++++++-
>> include/linux/sed-opal.h | 2 +
>> include/uapi/linux/sed-opal.h | 20 +++++
>> 4 files changed, 196 insertions(+), 2 deletions(-)
>>
>
> I'll review this over the weekend. Is this essentially the same thing
> we reviewed a month or two ago or are there little differences due to
> it be split across two different series?
The first patch (block: sed-opal: add ioctl for done-mark of shadow mbr)
is a bit different because a new struct and enum were introduced. The rest
is pretty much the same. That's also why I kept the reviewd-by tags.
Best regards,
David
prev parent reply other threads:[~2019-05-02 16:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 23:20 David Kozub
2019-04-30 23:20 ` [PATCH 1/3] block: sed-opal: add ioctl for done-mark of shadow mbr David Kozub
2019-05-01 10:36 ` David Kozub
2019-05-01 13:46 ` Christoph Hellwig
2019-05-05 14:16 ` Scott Bauer
2019-05-06 20:02 ` Derrick, Jonathan
2019-04-30 23:20 ` [PATCH 2/3] block: sed-opal: ioctl for writing to " David Kozub
2019-05-01 13:48 ` Christoph Hellwig
2019-05-05 14:22 ` Scott Bauer
2019-04-30 23:20 ` [PATCH 3/3] block: sed-opal: check size of " David Kozub
2019-05-05 14:27 ` Scott Bauer
2019-05-06 20:15 ` Derrick, Jonathan
2019-05-01 13:49 ` [PATCH 0/3] block: sed-opal: add support for shadow MBR done flag and write Christoph Hellwig
2019-05-03 20:32 ` David Kozub
2019-05-05 14:43 ` Scott Bauer
2019-05-09 19:31 ` Derrick, Jonathan
2019-05-13 22:12 ` David Kozub
2019-05-02 12:30 ` Scott Bauer
2019-05-02 16:03 ` David Kozub [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1905021749060.929@linux.fjfi.cvut.cz \
--to=zub@linux.fjfi.cvut.cz \
--cc=axboe@kernel.dk \
--cc=jonas.rabenstein@studium.uni-erlangen.de \
--cc=jonathan.derrick@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sbauer@plzdonthack.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®