From: Jiri Kosina <jkosina@suse.cz>
To: Matheos Worku <Matheos.Worku@Sun.COM>
Cc: Peter Huewe <PeterHuewe@gmx.de>, Alan Cox <alan@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] char/vme_scc: adding __init macro to vme_scc.c
Date: Fri, 9 Oct 2009 17:04:22 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.00.0910091704010.19284@wotan.suse.de> (raw)
In-Reply-To: <4A8DB766.9020701@sun.com>
On Thu, 20 Aug 2009, Matheos Worku wrote:
> > Alan or Geert, please have a look at the small patch and either pull it
> > through your tree, or please ack' it so Jiri can pull it through the trivial
> > tree.
> >
> > linux version 2.6.31-rc6 - linus git tree, Do 20. Aug 22:26:06 CEST 2009
> >
> > Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> > ---
> > diff --git a/drivers/char/vme_scc.c b/drivers/char/vme_scc.c
> > index 994e1a5..8b24729 100644
> > --- a/drivers/char/vme_scc.c
> > +++ b/drivers/char/vme_scc.c
> > @@ -136,7 +136,7 @@ static const struct tty_port_operations scc_port_ops = {
> > * vme_scc_init() and support functions
> > *---------------------------------------------------------------------------*/
> > -static int scc_init_drivers(void)
> > +static int __init scc_init_drivers(void)
> > {
> > int error;
> > @@ -172,7 +172,7 @@ static int scc_init_drivers(void)
> > /* ports[] array is indexed by line no (i.e. [0] for ttyS0, [1] for ttyS1).
> > */
> > -static void scc_init_portstructs(void)
> > +static void __init scc_init_portstructs(void)
> > {
> > struct scc_port *port;
> > int i;
> > @@ -195,7 +195,7 @@ static void scc_init_portstructs(void)
> > #ifdef CONFIG_MVME147_SCC
> > -static int mvme147_scc_init(void)
> > +static int __init mvme147_scc_init(void)
> > {
> > struct scc_port *port;
> > int error;
> > @@ -298,7 +298,7 @@ fail:
> > #ifdef CONFIG_MVME162_SCC
> > -static int mvme162_scc_init(void)
> > +static int __init mvme162_scc_init(void)
> > {
> > struct scc_port *port;
> > int error;
> > @@ -404,7 +404,7 @@ fail:
> > #ifdef CONFIG_BVME6000_SCC
> > -static int bvme6000_scc_init(void)
> > +static int __init bvme6000_scc_init(void)
> > {
> > struct scc_port *port;
> > int error;
> > @@ -503,7 +503,7 @@ fail_free_b_rx:
> > #endif
> > -static int vme_scc_init(void)
> > +static int __init vme_scc_init(void)
> > {
> > int res = -ENODEV;
> Then there are issnvram.txt iss.conf etc ... I guess we need to change
> these as well. How about error messages? I assume they would have ISS in
> them.
Confused ... how is this related to the patch?
--
Jiri Kosina
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2009-10-09 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 20:42 Peter Huewe
2009-08-20 20:51 ` Matheos Worku
2009-10-09 15:04 ` Jiri Kosina [this message]
2009-12-22 7:10 ` Peter Huewe
2009-08-20 21:01 ` Peter Huewe
2009-09-29 12:26 ` Peter Hüwe
2009-12-23 18:38 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.0910091704010.19284@wotan.suse.de \
--to=jkosina@suse.cz \
--cc=Matheos.Worku@Sun.COM \
--cc=PeterHuewe@gmx.de \
--cc=alan@redhat.com \
--cc=geert@linux-m68k.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®