From: Jiri Kosina <jkosina@suse.cz>
To: Peng Tao <bergwolf@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: fix comments for invalidate_inode_pages2()
Date: Mon, 19 Oct 2009 09:06:49 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.00.0910190906220.8582@wotan.suse.de> (raw)
In-Reply-To: <1255934893-7696-1-git-send-email-bergwolf@gmail.com>
On Mon, 19 Oct 2009, Peng Tao wrote:
> invalidate_inode_pages2() returns -EBUSY *NOT* -EIO if any pages could not be
> invalidated.
>
> Signed-off-by: Peng Tao <bergwolf@gmail.com>
> ---
> mm/truncate.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/truncate.c b/mm/truncate.c
> index 450cebd..2c147a7 100644
> --- a/mm/truncate.c
> +++ b/mm/truncate.c
> @@ -490,7 +490,7 @@ EXPORT_SYMBOL_GPL(invalidate_inode_pages2_range);
> * Any pages which are found to be mapped into pagetables are unmapped prior to
> * invalidation.
> *
> - * Returns -EIO if any pages could not be invalidated.
> + * Returns -EBUSY if any pages could not be invalidated.
> */
> int invalidate_inode_pages2(struct address_space *mapping)
> {
Right, this way it's consistent with invalidate_inode_pages2_range().
Applied, thanks.
--
Jiri Kosina
SUSE Labs, Novell Inc.
prev parent reply other threads:[~2009-10-19 7:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 6:48 Peng Tao
2009-10-19 7:06 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.0910190906220.8582@wotan.suse.de \
--to=jkosina@suse.cz \
--cc=bergwolf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®