From: Jiri Kosina <jkosina@suse.cz>
To: Thiago Farina <tfransosi@gmail.com>
Cc: "André Goddard Rosa" <andre.goddard@gmail.com>,
"linux list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] trivial: fix assorted typos all over the place
Date: Mon, 2 Nov 2009 19:40:10 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.00.0911021937240.4203@wotan.suse.de> (raw)
In-Reply-To: <a4c8a6d00911021029n3b34c0b0w9acd3f82a07ae766@mail.gmail.com>
On Mon, 2 Nov 2009, Thiago Farina wrote:
> I thought that this kind of patches were not allowed.
By whom?
> Don't you need to split this in individual patches, to make the work in
> reviewing this, more easier?
I'd say -- just use common sense. Comment typo fixes aren't big deal,
really.
If all the changes are just in the comments/help texts, then reviewing it
is really quite easy task which one can easily do while stuck/bored/too
tired to do other things which would actually require some thinking.
That said, if the spelling fixes touch some real code (variables/macro
defines etc), then they'd of course better be separated.
--
Jiri Kosina
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2009-11-02 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 17:49 André Goddard Rosa
2009-11-02 18:29 ` Thiago Farina
2009-11-02 18:40 ` Jiri Kosina [this message]
2009-11-04 10:45 ` André Goddard Rosa
2009-11-04 12:02 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.0911021937240.4203@wotan.suse.de \
--to=jkosina@suse.cz \
--cc=andre.goddard@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®