From: Hugh Dickins <hughd@google.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Ric Wheeler <ricwheeler@gmail.com>,
Christian Brandt <brandtc@psi5.com>,
linux-kernel@vger.kernel.org, Mike Snitzer <snitzer@redhat.com>
Subject: Re: swap storage alignment and stride size
Date: Wed, 15 Dec 2010 16:42:33 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.00.1012151627400.8734@tigran.mtv.corp.google.com> (raw)
In-Reply-To: <yq18vzq6dgb.fsf@sermon.lab.mkp.net>
On Wed, 15 Dec 2010, Martin K. Petersen wrote:
> >>>>> "Hugh" == Hugh Dickins <hughd@google.com> writes:
>
> Hugh> (scan_swap_map does try to allocate in 1MB clusters, but they're
> Hugh> not written out that way, and there's no attempt to align: if it
> Hugh> worked out better for the lower level to require that these 1MB
> Hugh> clusters are aligned, we could probably go for that - though the
> Hugh> swap header page might then be a nuisance.)
>
> You called it a "header page". Does that imply that it is page sized?
Yes. (Rather a nuisance on a PowerPC system which sometimes uses
a kernel with 4k pages and sometimes a kernel with 64k pages.)
> Or will it cause pages written to a 4k-aligned swap device to be
> misaligned?
No, the 4k-aligned remains 4k-aligned, of course. But if you aligned
your swap partition on, say, a 1MB boundary, and are thinking of
working in aligned 1MB blocks, then it may be awkward that there's
always this special 4k at the start (it could be written back each
time even though it hasn't changed, but it's still an odd case).
Hugh
next prev parent reply other threads:[~2010-12-16 0:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 17:03 Christian Brandt
2010-12-08 19:56 ` Ric Wheeler
2010-12-14 20:00 ` Martin K. Petersen
2010-12-15 4:57 ` Hugh Dickins
2010-12-15 19:30 ` Martin K. Petersen
2010-12-16 0:42 ` Hugh Dickins [this message]
2010-12-16 23:46 ` Martin K. Petersen
2010-12-17 0:15 ` Christian Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.1012151627400.8734@tigran.mtv.corp.google.com \
--to=hughd@google.com \
--cc=brandtc@psi5.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ricwheeler@gmail.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®