mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hughd@google.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Hugh Dickins <hughd@google.com>, Takashi Iwai <tiwai@suse.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	Giacomo Comes <comes@naic.edu>,
	linux-kernel@vger.kernel.org
Subject: Re: i915 regression on 3.6-rc1: lid blanks screen
Date: Mon, 6 Aug 2012 11:25:30 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LSU.2.00.1208061122060.1425@eggly.anvils> (raw)
In-Reply-To: <CAKMK7uHZ3F9neO6=ZX2MFLzYmincPeEF23udgZ-0YJ0R+WHEkg@mail.gmail.com>

On Mon, 6 Aug 2012, Daniel Vetter wrote:
> On Mon, Aug 6, 2012 at 6:21 AM, Hugh Dickins <hughd@google.com> wrote:
> > On Sun, 5 Aug 2012, Takashi Iwai wrote:
> >> At Sat, 4 Aug 2012 10:01:13 -0700 (PDT),
> >> Hugh Dickins wrote:
> >> >
> >> > Sorry to report that with 3.6-rc1, closing and opening the lid on
> >> > this ThinkPad T420s leaves the screen blank, and I have to reboot.
> >> >
> >> > Bisection led to this commit, and reverting indeed gets my screen back:
> >> >
> >> > commit 520c41cf2fa029d1e8b923ac2026f96664f17c4b
> >> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> >> > Date:   Wed Jul 11 16:27:52 2012 +0200
> >> >
> >> >     drm/i915/lvds: ditch ->prepare special case
> > ...
> >>
> >> Hm, it's surprising.
> >>
> >> Could you check whether the counter-part intel_lvds_enable() is
> >> called?  If the prepare callback affects, it must be from the mode
> >> setting (drm_crtc_helper_set_mode()).
> >
> > Yes, I put a dump_stack() in both, and intel_lvds_enable() gets called
> > about 0.28 seconds after the intel_lvds_disable() when I lift the lid;
> > but with no video display until I revert that commit.
> 
> Can you please boot with drm.debug=0xe added to your kernel cmdline,
> reproduce the issue (with the two dump_stack calls added) and then
> attach the full dmesg?

Collected, I'll send it to you both privately in a moment.

> 
> Also a few other things to try: What happens if you do a modeset on
> the LVDS while it's still working, e.g.

In the dmesg, I've only gone to runlevel 3, simply working on the
console without startx.  For these xrandrs to work, I did startx
and used the graphics screen.

> 
> xrandr --outpu LVDS1 --auto --crtc 1

Blanks and restores the screen.

> 
> then switch back to crtc 0 with
> 
> xrandr --outpu LVDS1 --auto --crtc 0

Blanks and restores the screen.

> 
> Would also be interesting to know whether this can resurrect your machine.

Indeed it does: the first (--crtc 1) restores the display from
its blank state after opening the lid, the second (--crtc 0) then
behaves as before, briefly blanking then restoring the display.

> 
> Also, how blank is the screen? I.e. is only the backlight off, but you
> can (dimly) see some screen contents, or is it completely off?

Completely off.

Thanks,
Hugh

  reply	other threads:[~2012-08-06 18:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-04 17:01 Hugh Dickins
2012-08-05  7:11 ` Takashi Iwai
2012-08-06  4:21   ` Hugh Dickins
2012-08-06  9:03     ` Daniel Vetter
2012-08-06 18:25       ` Hugh Dickins [this message]
2012-08-10 11:59         ` Takashi Iwai
2012-08-10 12:35           ` Daniel Vetter
2012-08-10 12:57             ` Takashi Iwai
2012-08-10 18:53               ` Hugh Dickins
2012-08-11  6:45                 ` Takashi Iwai
2012-08-11  6:56                   ` [PATCH v2] drm/i915: Fix blank panel at reopening lid Takashi Iwai
2012-08-11 19:15                     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.00.1208061122060.1425@eggly.anvils \
    --to=hughd@google.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=comes@naic.edu \
    --cc=daniel.vetter@ffwll.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®