From: Hugh Dickins <hughd@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kees Cook <keescook@chromium.org>,
Ard Biesheuvel <ard.biesheuvel@gmail.com>,
linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Ingo Molnar <mingo@kernel.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
James Morris <jmorris@namei.org>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] hardening: add PROT_FINAL prot flag to mmap/mprotect
Date: Tue, 2 Oct 2012 17:43:20 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.00.1210021733580.1343@eggly.anvils> (raw)
In-Reply-To: <20121002153841.a03ad73b.akpm@linux-foundation.org>
On Tue, 2 Oct 2012, Andrew Morton wrote:
> On Tue, 2 Oct 2012 15:10:56 -0700
> Kees Cook <keescook@chromium.org> wrote:
>
> > >> Has there been any more progress on this patch over-all?
> > >
> > > No progress.
> >
> > Al, Andrew, anyone? Thoughts on this?
> > (First email is https://lkml.org/lkml/2012/8/14/448)
>
> Wasn't cc'ed, missed it.
>
> The patch looks straightforward enough. Have the maintainers of the
> runtime linker (I guess that's glibc) provided any feedback on the
> proposal?
It looks reasonable to me too. I checked through VM_MAYflag handling
and don't expect surprises (a few places already turn off VM_MAYWRITE
in much the same way that this does, I hadn't realized).
I'm disappointed to find that our mmap() is lax about checking its
PROT and MAP args, so old kernels will accept PROT_FINAL but do
nothing with it. Luckily mprotect() is stricter, so that can be
used to check for whether it's supported.
The patch does need to be slightly extended though: alpha, mips,
parisc and xtensa have their own include/asm/mman.h, which does
not include asm-generic/mman-common.h at all.
Hugh
next prev parent reply other threads:[~2012-10-03 0:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 19:11 Ard Biesheuvel
2012-08-20 18:00 ` Kees Cook
2012-08-20 21:48 ` Ard Biesheuvel
2012-10-02 20:34 ` Kees Cook
2012-10-02 21:41 ` Ard Biesheuvel
2012-10-02 22:10 ` Kees Cook
2012-10-02 22:38 ` Andrew Morton
2012-10-03 0:43 ` Hugh Dickins [this message]
2012-10-03 14:43 ` Updated: " Ard Biesheuvel
2012-10-03 16:25 ` Kees Cook
2012-10-03 19:44 ` Hugh Dickins
2012-10-03 21:18 ` Andrew Morton
2012-10-03 22:19 ` Kees Cook
2012-10-03 22:25 ` Roland McGrath
2012-10-04 8:26 ` Ard Biesheuvel
2012-10-04 12:51 ` PaX Team
2012-10-04 13:56 ` Ard Biesheuvel
2012-10-06 13:11 ` PaX Team
2012-10-07 7:43 ` Ard Biesheuvel
2012-10-08 0:23 ` PaX Team
2012-10-10 18:26 ` halfdog
2012-10-04 8:18 ` Mikael Pettersson
2012-10-04 10:33 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.1210021733580.1343@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@gmail.com \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=khlebnikov@openvz.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome