From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932234AbaFCADK (ORCPT ); Mon, 2 Jun 2014 20:03:10 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:49552 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753284AbaFCADG (ORCPT ); Mon, 2 Jun 2014 20:03:06 -0400 Date: Mon, 2 Jun 2014 17:01:44 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: David Rientjes cc: Hugh Dickins , Andrew Morton , Johannes Weiner , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org Subject: Re: [patch] mm, memcg: periodically schedule when emptying page list In-Reply-To: Message-ID: References: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Jun 2014, David Rientjes wrote: > On Mon, 2 Jun 2014, Hugh Dickins wrote: > > > Why not just move that cond_resched() down below the if/else? > > No need to test need_resched() separately, and this page is not busy. > > > > Would you like to propose your version from our kernel instead? If that's how you prefer to work it, sure. The patch would indeed look uncannily like what I put in our kernel a week ago; but I think the description might owe a lot to you! I'll get to it later, while secretly hoping you get to it sooner :) Hugh