mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hughd@google.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	Dominique Martinet <asmadeus@codewreck.org>,
	Hugh Dickins <hughd@google.com>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Dominique Martinet <dominique.martinet@cea.fr>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	David Howells <dhowells@redhat.com>
Subject: Re: [git pull] vfs.git spurious ENOTDIR fix
Date: Sat, 1 Aug 2015 21:06:55 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LSU.2.11.1508012045250.17084@eggly.anvils> (raw)
In-Reply-To: <CA+55aFwrctpGzdFBsqwz97NOUBbWncdik-axas1vcNeyUXFHrA@mail.gmail.com>

On Sat, 1 Aug 2015, Linus Torvalds wrote:
> 
> Well, I'd not be against continuing cleanups for 4.3... Well, as long
> as we can make sure 4.2 is solid first, of course. I'd still like to
> have Hugh verify that the current -git tree works for his load, but
> obviously that wasn't easily reproducible, so that will presumably
> take a few days. Dominique seems to at least not see it any more with
> that patch.

I've had Al's patch under load since this morning, and it's going fine.
But I've not actually managed to reproduce the issue for several days
now, however bogus a "fix" I've been testing.  So certainly don't wait
to hear from me: but of course I'll keep on with the loads, and shout
if it does go wrong again.

(I don't actually understand why the clearing of DCACHE_ENTRY_TYPE in
dentry_iput() is not of continuing concern; but don't worry, there's
plenty I don't understand - so long as you're both satisfied that
it's not a concern, no need to persuade me.)

Do we have any idea why a bug introduced in v3.13 should only now
stand out, both for Dominique and for me?  Has the RCU lookup somehow
become much more effective recently?  (I don't think symlinks were a
big deal for either of us, though the kernel build does use some).

Hugh

  reply	other threads:[~2015-08-02  4:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31 17:46 v4.2-rc dcache regression, probably 75a6f82a0d10 Hugh Dickins
2015-07-31 17:59 ` Dominique Martinet
2015-07-31 18:00 ` J. Bruce Fields
2015-07-31 18:42 ` Linus Torvalds
2015-07-31 19:42   ` Hugh Dickins
2015-07-31 20:50     ` Dominique Martinet
2015-07-31 22:52       ` Linus Torvalds
2015-08-01  0:20         ` Hugh Dickins
2015-08-01  5:58           ` Dominique Martinet
2015-08-01  7:26         ` Al Viro
2015-08-01 10:19           ` Dominique Martinet
2015-08-01 10:50             ` Dominique Martinet
2015-08-01 16:09           ` Linus Torvalds
2015-08-01 17:09             ` Al Viro
2015-08-02  0:14             ` [git pull] vfs.git spurious ENOTDIR fix Al Viro
2015-08-02  0:23               ` Al Viro
2015-08-02  0:42                 ` Linus Torvalds
2015-08-02  0:57                 ` Linus Torvalds
2015-08-02  1:41                   ` Al Viro
2015-08-02  2:39                     ` Linus Torvalds
2015-08-02  4:06                       ` Hugh Dickins [this message]
2015-08-02  4:39                         ` Al Viro
2015-08-02  4:42                         ` Linus Torvalds
2015-08-02 18:53                           ` Hugh Dickins
2015-08-01  0:09       ` v4.2-rc dcache regression, probably 75a6f82a0d10 Hugh Dickins
2015-08-01  4:20     ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.11.1508012045250.17084@eggly.anvils \
    --to=hughd@google.com \
    --cc=asmadeus@codewreck.org \
    --cc=bfields@fieldses.org \
    --cc=dhowells@redhat.com \
    --cc=dominique.martinet@cea.fr \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®