From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752932AbcAGMTn (ORCPT ); Thu, 7 Jan 2016 07:19:43 -0500 Received: from er-systems.de ([148.251.68.21]:46894 "EHLO er-systems.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750809AbcAGMTj (ORCPT ); Thu, 7 Jan 2016 07:19:39 -0500 X-Greylist: delayed 438 seconds by postgrey-1.27 at vger.kernel.org; Thu, 07 Jan 2016 07:19:39 EST Date: Thu, 7 Jan 2016 13:12:16 +0100 (CET) From: Thomas Voegtle X-X-Sender: thomas@er-systems.de To: Borislav Petkov cc: Markus Trippelsdorf , linux-kernel@vger.kernel.org Subject: Re: x86/microcode update on systems without INITRD In-Reply-To: <20151120082716.GA4028@pd.tnic> Message-ID: References: <20151119214301.GA318@x4> <20151119215543.GA4926@pd.tnic> <20151119225828.GB4926@pd.tnic> <20151120071920.GA321@x4> <20151120082716.GA4028@pd.tnic> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Virus-Checker-Version: clamassassin 1.2.4 with clamdscan / ClamAV 0.99/21233/Thu Jan 7 10:35:27 2016 signatures 55. Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Nov 2015, Borislav Petkov wrote: > On Fri, Nov 20, 2015 at 08:19:20AM +0100, Markus Trippelsdorf wrote: >> On 2015.11.19 at 23:58 +0100, Borislav Petkov wrote: >>> On Thu, Nov 19, 2015 at 10:55:43PM +0100, Borislav Petkov wrote: >>>> On Thu, Nov 19, 2015 at 10:43:01PM +0100, Markus Trippelsdorf wrote: >>>>> It looks like the ability to update x86/microcode without using an >>>>> initrd was removed this merge window. >>>> >>>> Whoops, that shouldnt've happened. Will debug it tomorrow and provide a >>>> fix. >>> >>> Anyway, the hunk below seems to work in my guest here, I'll run it >>> on the rest of the boxes tomorrow. In case you want to give it a try >>> before: >> >> Your patch works fine. Thanks. > > Thanks for testing. > >> But of course it needs this additional patch, otherwise the microcode >> loader wouldn't build at all: >> >> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >> index db3622f22b61..52c6964e24bd 100644 >> --- a/arch/x86/Kconfig >> +++ b/arch/x86/Kconfig >> @@ -1126,7 +1126,6 @@ config MICROCODE >> bool "CPU microcode loading support" >> default y >> depends on CPU_SUP_AMD || CPU_SUP_INTEL >> - depends on BLK_DEV_INITRD >> select FW_LOADER >> ---help--- > > That dependency is a must as the early loader needs the initrd support. I just diffed my 4.3 config with the 4.4 config and saw that the whole Microcode stuff was silently dropped by a normal "make oldconfig". Wouldn't be something like this much nicer to give a hint? diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index db3622f..75523a0 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -1126,7 +1126,7 @@ config MICROCODE bool "CPU microcode loading support" default y depends on CPU_SUP_AMD || CPU_SUP_INTEL - depends on BLK_DEV_INITRD + select BLK_DEV_INITRD select FW_LOADER ---help--- At least I would have noticed it? Thomas