From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751063AbcEBENf (ORCPT ); Mon, 2 May 2016 00:13:35 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:33511 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbcEBEN1 (ORCPT ); Mon, 2 May 2016 00:13:27 -0400 Date: Sun, 1 May 2016 21:13:18 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Andrew Morton cc: Matthew Wilcox , Ross Zwisler , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH mmotm] radix-tree: rewrite radix_tree_locate_item fix Message-ID: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org radix_tree_locate_item() is often returning the wrong index, causing swapoff of shmem to hang because it cannot find the swap entry there. __locate()'s use of base is bogus, it adds an offset twice into index. Signed-off-by: Hugh Dickins --- Fix to radix-tree-rewrite-radix_tree_locate_item.patch lib/radix-tree.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- 4.6-rc5-mm1/lib/radix-tree.c 2016-04-30 22:55:06.067184898 -0700 +++ linux/lib/radix-tree.c 2016-05-01 18:52:06.668085420 -0700 @@ -1254,15 +1254,14 @@ struct locate_info { static unsigned long __locate(struct radix_tree_node *slot, void *item, unsigned long index, struct locate_info *info) { - unsigned long base, i; + unsigned long i; do { unsigned int shift = slot->shift; - base = index & ~((1UL << shift) - 1); for (i = (index >> shift) & RADIX_TREE_MAP_MASK; i < RADIX_TREE_MAP_SIZE; - i++, index = base + (i << shift)) { + i++, index += (1UL << shift)) { struct radix_tree_node *node = rcu_dereference_raw(slot->slots[i]); if (node == RADIX_TREE_RETRY)