From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759709AbcIPTGg (ORCPT <rfc822;w@1wt.eu>);
        Fri, 16 Sep 2016 15:06:36 -0400
Received: from mail-pf0-f172.google.com ([209.85.192.172]:35278 "EHLO
        mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754490AbcIPTG2 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 16 Sep 2016 15:06:28 -0400
Date: Fri, 16 Sep 2016 12:06:11 -0700 (PDT)
From: Hugh Dickins <hughd@google.com>
X-X-Sender: hugh@eggly.anvils
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Andrew Morton <akpm@linux-foundation.org>
cc: Hugh Dickins <hughd@google.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/shmem.c: constify anon_ops
In-Reply-To: <1473890528-7009-1-git-send-email-linux@rasmusvillemoes.dk>
Message-ID: <alpine.LSU.2.11.1609161203350.4175@eggly.anvils>
References: <1473890528-7009-1-git-send-email-linux@rasmusvillemoes.dk>
User-Agent: Alpine 2.11 (LSU 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 15 Sep 2016, Rasmus Villemoes wrote:

> Every other dentry_operations instance is const, and this one might as
> well be.
> 
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Indeed, thanks,

Acked-by: Hugh Dickins <hughd@google.com>

> ---
>  mm/shmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/shmem.c b/mm/shmem.c
> index fd8b2b5741b1..693ffdc5899a 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -4077,7 +4077,7 @@ EXPORT_SYMBOL_GPL(shmem_truncate_range);
>  
>  /* common code */
>  
> -static struct dentry_operations anon_ops = {
> +static const struct dentry_operations anon_ops = {
>  	.d_dname = simple_dname
>  };
>  
> -- 
> 2.1.4