From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D22C433E0 for ; Sat, 6 Mar 2021 20:28:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E69F6650B1 for ; Sat, 6 Mar 2021 20:28:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231363AbhCFU1p (ORCPT ); Sat, 6 Mar 2021 15:27:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231403AbhCFU1k (ORCPT ); Sat, 6 Mar 2021 15:27:40 -0500 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E227AC06174A for ; Sat, 6 Mar 2021 12:27:39 -0800 (PST) Received: by mail-ot1-x333.google.com with SMTP id t16so5369822ott.3 for ; Sat, 06 Mar 2021 12:27:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=e+Ere75oCQWSmOpz788sW6R8AeYpQOZY+AlLnzPu4nA=; b=bHiG1PFbENrTJVDVaHEaQuHfTjv1dRM7IAWNveS0CXsm+sgC/S2oWK09PHS0f81eB4 6hYdFYtYnDaCLTYFcfHudB+xPGwqtdmfasK81Yp99CgjcpcpgwD4i0phOAl0gb2I6PDI vD56JUFiZC3h8x2/RmxUw1d93TMHJyUg8BCzGYaMxKZi2QHcO5fIoVnhWqyOk57t2uRf n8fmtOI0K0VWA1md6QgNjXIqUjA8+CnGAJMvy9fmmpdi7n6b8vaFnFydMXk70gWq71pl TldQLkfwZdPeyHCrgFi43L/tkEGla9A8akQ8Ea5F/hNmPkpDQdWBUUsTFoFWqeeQP6ph 2pXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=e+Ere75oCQWSmOpz788sW6R8AeYpQOZY+AlLnzPu4nA=; b=m7AzP3ZTygHGiD8WzGLaubX3seOrnkMcJwimyBNi0KJEUrH6DPunjYjj0TrA+CtcFH I3a519xiRJBDfNZ1AJN8chlfuJPeEg0l5CEbkd8shjGLtc94VZMxCgr4lyfnVFW3kKTF 5U5jrFhYf+qjMlWOQpQQPi7wDrzoqS+LeeptvRjp4pGjoGGozmqvriTO38TbxzQRYFL/ Qk0qP29wawxk2nUY0hGcmlvhhLIIgS2GMFHsNeUfv/k3LrNajs8HWFNXKQ8/tGPjVIur mOdwf+sgJ9gHbQWC2F1GZoelLMnFKHhV/SqNoLHn8+skSzjtCpw+WKynHID+y3bcRK79 yXxw== X-Gm-Message-State: AOAM531NBEXIauUr+Pl/gxbaTJYJXrcd6X1HoGirWeKaWMKqzFYs9PYC oBHstEs8AejSRb5BWxmKx2j2cQ== X-Google-Smtp-Source: ABdhPJyVdqrQqI1rCj7xVOLaAzCPfpgEQigRntSoNrMPuYhqNPFkbrb2axkAOhPmmr++12qr3k6eLw== X-Received: by 2002:a05:6830:15:: with SMTP id c21mr4570241otp.20.1615062459173; Sat, 06 Mar 2021 12:27:39 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id w1sm1401471oop.1.2021.03.06.12.27.38 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Sat, 06 Mar 2021 12:27:38 -0800 (PST) Date: Sat, 6 Mar 2021 12:27:09 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Sedat Dilek cc: Hugh Dickins , Luca Coelho , Kalle Valo , Mordechay Goodstein , Jiri Kosina , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] iwlwifi: fix DVM build regression in 5.12-rc In-Reply-To: Message-ID: References: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 6 Mar 2021, Sedat Dilek wrote: > On Sat, Mar 6, 2021 at 8:48 PM Hugh Dickins wrote: > > > > There is no iwl_so_trans_cfg if CONFIG_IWLDVM but not CONFIG_IWLMVM: > > move the CONFIG_IWLMVM guard up before the problematic SnJ workaround > > to fix the build breakage. > > > > Fixes: 930be4e76f26 ("iwlwifi: add support for SnJ with Jf devices") > > Signed-off-by: Hugh Dickins > > See "iwlwifi: pcie: fix iwl_so_trans_cfg link error when CONFIG_IWLMVM > is disabled" in [1]. > > - Sedat - > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=62541e266703549550e77fd46138422dbdc881f1 Thanks for looking out that and the other one, Sedat: I swear I checked linux-next before sending, but my check seems to have been... defective. Hugh