From: Jan Engelhardt <jengelh@inai.de>
To: Baole Ni <baolex.ni@intel.com>
Cc: Linux Networking Developer Mailing List <netdev@vger.kernel.org>,
lvs-devel@vger.kernel.org,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
chuansheng.liu@intel.com
Subject: Re: [PATCH 1116/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 20:07:11 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.20.1608022006070.25634@nerf40.vanv.qr> (raw)
In-Reply-To: <20160802121754.24527-1-baolex.ni@intel.com>
On Tuesday 2016-08-02 14:17, Baole Ni wrote:
>I find that the developers often just specified the numeric value
>when calling a macro which is defined with a parameter for access permission.
>As we know, these numeric value for access permission have had the corresponding macro,
>and that using macro can improve the robustness and readability of the code,
>thus, I suggest replacing the numeric parameter with the macro.
>
> static int ip_vs_conn_tab_bits = CONFIG_IP_VS_TAB_BITS;
>-module_param_named(conn_tab_bits, ip_vs_conn_tab_bits, int, 0444);
>+module_param_named(conn_tab_bits, ip_vs_conn_tab_bits, int, S_IRUSR | S_IRGRP | S_IROTH);
We have S_IRUGO for this.
next prev parent reply other threads:[~2016-08-02 19:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 12:17 Baole Ni
2016-08-02 18:07 ` Jan Engelhardt [this message]
2016-08-02 19:13 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1608022006070.25634@nerf40.vanv.qr \
--to=jengelh@inai.de \
--cc=baolex.ni@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®