From: Jiri Kosina <jikos@kernel.org>
To: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] HID: intel-ish-hid: add printf attribute to print_log()
Date: Mon, 2 Jan 2017 13:17:04 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.20.1701021316460.28985@cbobk.fhfr.pm> (raw)
In-Reply-To: <20161222100910.6179-1-nicolas.iooss_linux@m4x.org>
On Thu, 22 Dec 2016, Nicolas Iooss wrote:
> Structure ishtp_device contains a logging function, print_log(), which
> formats some of its parameters using vsnprintf(). Add a __printf
> attribute to this function field (and to ish_event_tracer()) in order to
> detect at compile time issues related to the printf-like formatting.
>
> While at it, make format parameter a const pointer as print_log() is not
> supposed to modify it.
Both patches applied to for-4.11/intel-ish. Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2017-01-02 12:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 10:09 Nicolas Iooss
2016-12-22 10:09 ` [PATCH 2/2] HID: intel-ish-hid: format 32-bit integers with %X Nicolas Iooss
2016-12-22 17:12 ` Srinivas Pandruvada
2016-12-22 17:11 ` [PATCH 1/2] HID: intel-ish-hid: add printf attribute to print_log() Srinivas Pandruvada
2017-01-02 12:17 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1701021316460.28985@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.iooss_linux@m4x.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®