From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935590AbdADMPy (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Jan 2017 07:15:54 -0500
Received: from mx2.suse.de ([195.135.220.15]:33890 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1757640AbdADMPM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Jan 2017 07:15:12 -0500
Date: Wed, 4 Jan 2017 13:15:09 +0100 (CET)
From: Jiri Kosina <jikos@kernel.org>
X-X-Sender: jkosina@pobox.suse.cz
To: Vlastimil Babka <vbabka@suse.cz>
cc: linux-kernel@vger.kernel.org,
        Matthew Wilcox <mawilcox@linuxonhyperv.com>
Subject: Re: [PATCH] floppy: replace wrong kmalloc(GFP_USER) with
 GFP_KERNEL
In-Reply-To: <20170104101931.10165-1-vbabka@suse.cz>
Message-ID: <alpine.LSU.2.20.1701041315020.28985@cbobk.fhfr.pm>
References: <20170104101931.10165-1-vbabka@suse.cz>
User-Agent: Alpine 2.20 (LSU 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 4 Jan 2017, Vlastimil Babka wrote:

> The raw_cmd_copyin() function does a kmalloc() with GFP_USER, although the
> allocated structure is obviously not mapped to userspace, just copied from/to.
> In this case GFP_KERNEL is more appropriate, so let's use it, although in the
> current implementation this does not manifest as any error.
> 
> Reported-by: Matthew Wilcox <mawilcox@linuxonhyperv.com>
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs