From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934728AbdAJKOz (ORCPT ); Tue, 10 Jan 2017 05:14:55 -0500 Received: from mx2.suse.de ([195.135.220.15]:45697 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934625AbdAJKOx (ORCPT ); Tue, 10 Jan 2017 05:14:53 -0500 Date: Tue, 10 Jan 2017 11:14:51 +0100 (CET) From: Miroslav Benes To: Josh Poimboeuf cc: x86@kernel.org, Dave Jones , Dmitry Vyukov , Andy Lutomirski , Brian Gerst , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] x86/unwind: include __schedule() in stack traces In-Reply-To: <598e9f7505ed0aba86e8b9590aa528c6c7ae8dcd.1483978430.git.jpoimboe@redhat.com> Message-ID: References: <598e9f7505ed0aba86e8b9590aa528c6c7ae8dcd.1483978430.git.jpoimboe@redhat.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Jan 2017, Josh Poimboeuf wrote: > In the following commit: > > 0100301bfdf5 ("sched/x86: Rewrite the switch_to() code") > > ... the layout of the 'inactive_task_frame' struct was designed to have > a frame pointer header embedded in it, so that the unwinder could use > the 'bp' and 'ret_addr' fields to report __schedule() on the stack (or > ret_from_fork() for newly forked tasks which haven't actually run yet). > > Finish the job by changing get_frame_pointer() to return a pointer to > inactive_task_frame's 'bp' field rather than 'bp' itself. This allows > the unwinder to start one frame higher on the stack, so that it properly > reports __schedule(). > > Reported-by: Miroslav Benes You can also add my Tested-by: Miroslav Benes One ignorant question below. > Signed-off-by: Josh Poimboeuf > --- > arch/x86/include/asm/stacktrace.h | 5 +---- > arch/x86/include/asm/switch_to.h | 10 +++++++++- > 2 files changed, 10 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/include/asm/stacktrace.h b/arch/x86/include/asm/stacktrace.h > index 20ce3db..2e41c50 100644 > --- a/arch/x86/include/asm/stacktrace.h > +++ b/arch/x86/include/asm/stacktrace.h > @@ -52,16 +52,13 @@ static inline bool on_stack(struct stack_info *info, void *addr, size_t len) > static inline unsigned long * > get_frame_pointer(struct task_struct *task, struct pt_regs *regs) > { > - struct inactive_task_frame *frame; > - > if (regs) > return (unsigned long *)regs->bp; > > if (task == current) > return __builtin_frame_address(0); > > - frame = (struct inactive_task_frame *)task->thread.sp; > - return (unsigned long *)READ_ONCE_NOCHECK(frame->bp); > + return &((struct inactive_task_frame *)task->thread.sp)->bp; You effectively remove one of the changes from the previous patch - READ_ONCE_NOCHECK. Is it intentional? Regards, Miroslav