From: Jiri Kosina <jikos@kernel.org>
To: Brendan McGrath <redmcg@redmandi.dyndns.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Victor Vlasenko <victor.vlasenko@sysgears.com>,
Frederik Wenigwieser <frederik.wenigwieser@gmail.com>
Subject: Re: [PATCHv3] HID: i2c-hid: Add sleep between POWER ON and RESET
Date: Wed, 11 Jan 2017 21:55:51 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.20.1701112155370.25515@cbobk.fhfr.pm> (raw)
In-Reply-To: <1483736498-7805-1-git-send-email-redmcg@redmandi.dyndns.org>
On Sat, 7 Jan 2017, Brendan McGrath wrote:
> Support for the Asus Touchpad was recently added. It turns out this
> device can fail initialisation (and become unusable) when the RESET
> command is sent too soon after the POWER ON command.
>
> Unfortunately the i2c-hid specification does not specify the need for
> a delay between these two commands. But it was discovered the Windows
> driver has a 1ms delay.
>
> As a result, this patch modifies the i2c-hid module to add a sleep
> inbetween the POWER ON and RESET commands which lasts between 1ms and 5ms.
>
> See https://github.com/vlasenko/hid-asus-dkms/issues/24 for further
> details.
>
> Signed-off-by: Brendan McGrath <redmcg@redmandi.dyndns.org>
> ---
> Changes since v2:
> - added comments to explain the reason for the sleep
Applied to for-4.10/upstream-fixes, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2017-01-11 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 4:10 [PATCH] HID: i2c-hid: Add quirk for sleep before reset Brendan McGrath
2017-01-05 11:23 ` Benjamin Tissoires
2017-01-05 22:53 ` [PATCHv2] HID: i2c-hid: Add sleep between POWER ON and RESET Brendan McGrath
2017-01-06 8:11 ` Benjamin Tissoires
2017-01-06 21:01 ` [PATCHv3] " Brendan McGrath
2017-01-06 22:02 ` Benjamin Tissoires
2017-01-11 20:55 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1701112155370.25515@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=frederik.wenigwieser@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=redmcg@redmandi.dyndns.org \
--cc=victor.vlasenko@sysgears.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®