From: Miroslav Benes <mbenes@suse.cz>
To: Jessica Yu <jeyu@redhat.com>
Cc: Abel Vesa <abelvesa@linux.com>,
linux@armlinux.org.uk, jpoimboe@redhat.com, jikos@kernel.org,
pmladek@suse.com, rostedt@goodmis.org, mingo@redhat.com,
gregkh@linuxfoundation.org, geert+renesas@glider.be,
davem@davemloft.net, akpm@linux-foundation.org,
emil.l.velikov@gmail.com, mchehab@kernel.org, linux@roeck-us.net,
ard.biesheuvel@linaro.org, jens.wiklander@linaro.org,
jean-philippe.brucker@arm.com, viro@zeniv.linux.org.uk,
stefano.stabellini@eu.citrix.com, chris.brandt@renesas.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
live-patching@vger.kernel.org
Subject: Re: arm: module: Add apply_relocate_add
Date: Wed, 18 Jan 2017 11:37:49 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.20.1701181133410.23458@pobox.suse.cz> (raw)
In-Reply-To: <20170117044921.GI9045@packer-debian-8-amd64.digitalocean.com>
On Mon, 16 Jan 2017, Jessica Yu wrote:
> +++ Abel Vesa [06/12/16 17:06 +0000]:
> > It was only added to fix compiler error. It is not implemented
> > yet.
> >
> > Signed-off-by: Abel Vesa <abelvesa@linux.com>
> > ---
> > arch/arm/kernel/module.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm/kernel/module.c b/arch/arm/kernel/module.c
> > index 4f14b5c..bf94922 100644
> > --- a/arch/arm/kernel/module.c
> > +++ b/arch/arm/kernel/module.c
> > @@ -52,6 +52,15 @@ void *module_alloc(unsigned long size)
> > #endif
> >
> > int
> > +apply_relocate_add(Elf32_Shdr *sechdrs, const char *strtab,
> > + unsigned int symindex, unsigned int relindex,
> > + struct module *module)
> > +{
> > + /* Not implemented yet */
> > + return 0;
> > +}
>
> Are SHT_RELA relocation sections actually supported on 32-bit arm? It looks
> like there's only support for SHT_REL.
>
> arch/arm/Kconfig:84: select MODULES_USE_ELF_REL
>
> If we support SHT_REL sections, the correct fix is to probably have
> klp_write_object_relocations() check if the relocation section is
> SHT_REL or SHT_RELA, and call the appropriate function (apply_relocate
> or apply_relocate_add), similar to how the module loader does it.
Agreed. According to arch/Kconfig and definitions you can use only one of
MODULES_USE_ELF_REL and MODULES_USE_ELF_RELA. arm arch uses the former. So
yes, I think we should use the same if/else construct from the module
loader in klp_write_object_relocations()... and it should go with this
patch set, because arm is the first arch to actually use SHT_REL and not
SHT_RELA (iiuc). x86, s390 and powerpc (archs we support) use SHT_RELA.
Miroslav
next prev parent reply other threads:[~2017-01-18 10:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 17:06 [PATCH 0/7] arm: Add livepatch support Abel Vesa
2016-12-06 17:06 ` [PATCH 1/7] arm: Add livepatch arch specific code Abel Vesa
2017-01-16 16:47 ` Miroslav Benes
2017-01-17 0:22 ` Jessica Yu
2017-01-17 2:27 ` Jessica Yu
2017-01-17 13:53 ` Miroslav Benes
2016-12-06 17:06 ` [PATCH 2/7] arm: ftrace: Add call modify mechanism Abel Vesa
2016-12-07 10:37 ` kbuild test robot
2016-12-06 17:06 ` [PATCH 3/7] arm: module: Add apply_relocate_add Abel Vesa
2016-12-07 2:08 ` kbuild test robot
2017-01-17 4:49 ` Jessica Yu
2017-01-18 10:37 ` Miroslav Benes [this message]
2016-12-06 17:06 ` [PATCH 4/7] arm: Add ftrace with regs support Abel Vesa
2016-12-07 2:43 ` Steven Rostedt
2016-12-07 10:57 ` Russell King - ARM Linux
2016-12-07 11:58 ` Robin Murphy
2016-12-07 12:10 ` Abel Vesa
2016-12-06 17:06 ` [PATCH 5/7] arm: ftrace: Add ARCH_SUPPORTS_FTRACE_OPS for ftrace with regs Abel Vesa
2016-12-06 17:06 ` [PATCH 6/7] arm: Add livepatch to build if CONFIG_LIVEPATCH Abel Vesa
2016-12-07 15:05 ` Petr Mladek
2016-12-07 16:11 ` Abel Vesa
2017-01-18 12:36 ` Miroslav Benes
2016-12-06 17:06 ` [PATCH 7/7] arm: Add livepatch necessary arch selects into Kconfig Abel Vesa
2016-12-07 2:45 ` Steven Rostedt
2016-12-07 6:48 ` kbuild test robot
2017-01-18 12:40 ` Miroslav Benes
2017-01-18 13:35 ` Russell King - ARM Linux
2016-12-07 1:38 ` [PATCH 0/7] arm: Add livepatch support zhouchengming
2016-12-07 11:39 ` Abel Vesa
2016-12-07 15:19 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1701181133410.23458@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=abelvesa@linux.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=chris.brandt@renesas.com \
--cc=davem@davemloft.net \
--cc=emil.l.velikov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jean-philippe.brucker@arm.com \
--cc=jens.wiklander@linaro.org \
--cc=jeyu@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=live-patching@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®